fix(release): push 缺失态 DRY + build-publishable - #79
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
- push-release 缺失态回退改用 listUnpushedExistingVersionTags(与 gh-release 共用现版本 tag 候选,LSP/DRY) - changeset-release 经 build-publishable 从 NPM_PUBLISH_PACKAGES 构建,去掉 YAML 手抄 workspace 列表(OCP) Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
4 tasks
Contributor
Author
There was a problem hiding this comment.
状态:已被 #80 超集
审查 main@cab68c5(世界包安装决策 push)时,将本 PR 意图一并落地并增强:
- push 缺失态 →
listUnpushedExistingVersionTags(同本 PR) build-publishable.mjs:全量拓扑改由package.jsondeps ∩NPM_PUBLISH_PACKAGES派生(不再硬编码 sdk/bds-tools 优先)- 额外 MAJOR:
npm-publish.yml应急补发改为--workspace依赖闭包(修 cli 缺 bds-tools dist) - 另含 world-packs occupancy DRY/LSP 小补丁
建议关闭本草稿,改合 #80 。
Sent by Cursor Automation: SFMC-Review
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
审查 main@5fd5384(#77 合入)后的残留 SOLID 债补丁。
changeset-push缺失态回退不再硬编码扫描@sfmc-bds/*,改为listUnpushedExistingVersionTags(候选与gh-release的listPackagesWithExistingVersionTags对齐,再过滤未推送)changeset-release构建步骤改为node tools/build-publishable.mjs,从NPM_PUBLISH_PACKAGES派生,去掉 YAML 手抄 workspace 列表Context
SFMC_GITHUB_TOKEN并 DRY 了 GitHub Release 回退;ootb / changeset-release 均 success,Version PR chore(release): version packages (beta) #78 已成功创建(PAT 生效)Test plan
node --test tools/changeset-release.test.mjs(11 pass)