Skip to content

fix(release): push 缺失态 DRY + build-publishable - #79

Closed
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-6d4766ad-fb04-4915-b2d5-0dad12864a5c-ae24
Closed

fix(release): push 缺失态 DRY + build-publishable#79
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/bc-6d4766ad-fb04-4915-b2d5-0dad12864a5c-ae24

Conversation

@cursor

@cursor cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

审查 main@5fd5384(#77 合入)后的残留 SOLID 债补丁。

  • MAJOR · DRY/LSPchangeset-push 缺失态回退不再硬编码扫描 @sfmc-bds/*,改为 listUnpushedExistingVersionTags(候选与 gh-releaselistPackagesWithExistingVersionTags 对齐,再过滤未推送)
  • MINOR · DRY/OCPchangeset-release 构建步骤改为 node tools/build-publishable.mjs,从 NPM_PUBLISH_PACKAGES 派生,去掉 YAML 手抄 workspace 列表

Context

Test plan

  • node --test tools/changeset-release.test.mjs(11 pass)
  • CI ootb on this PR
Open in Web View Automation 

- push-release 缺失态回退改用 listUnpushedExistingVersionTags(与 gh-release 共用现版本 tag 候选,LSP/DRY)
- changeset-release 经 build-publishable 从 NPM_PUBLISH_PACKAGES 构建,去掉 YAML 手抄 workspace 列表(OCP)

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

状态:已被 #80 超集

审查 main@cab68c5(世界包安装决策 push)时,将本 PR 意图一并落地并增强:

  • push 缺失态 → listUnpushedExistingVersionTags(同本 PR)
  • build-publishable.mjs:全量拓扑改由 package.json deps ∩ NPM_PUBLISH_PACKAGES 派生(不再硬编码 sdk/bds-tools 优先)
  • 额外 MAJORnpm-publish.yml 应急补发改为 --workspace 依赖闭包(修 cli 缺 bds-tools dist)
  • 另含 world-packs occupancy DRY/LSP 小补丁

建议关闭本草稿,改合 #80

View PR

Open in Web View Automation 

Sent by Cursor Automation: SFMC-Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants