Skip to content

fix(release): 对齐 SFMC_GITHUB_TOKEN + DRY GitHub Release 回退 - #77

Merged
Tanya7z merged 1 commit into
mainfrom
cursor/bc-32bd9c6b-fa66-4b13-871b-69cd569d8290-a006
Jul 25, 2026
Merged

fix(release): 对齐 SFMC_GITHUB_TOKEN + DRY GitHub Release 回退#77
Tanya7z merged 1 commit into
mainfrom
cursor/bc-32bd9c6b-fa66-4b13-871b-69cd569d8290-a006

Conversation

@cursor

@cursor cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

审查 main@7d92a08(合入 #76)后的残留问题补丁。CI(ootb / changeset-release)已绿,并成功发布 @sfmc-bds/tools@0.2.0-beta.1;本 PR 修 SOLID 债,不修失败 WF。

审查发现

级别 原则 问题
MAJOR DRY #76 文档/YAML 注释写 CHANGESETS_GITHUB_TOKEN,维护者合入前已改为 SFMC_GITHUB_TOKEN,权威名漂移
MAJOR DRY changeset-github-release.mjs 手写 tag -l 扫描,与 listPackagesWithExistingVersionTags 重复

修复

  1. workflowSFMC_GITHUB_TOKEN \|\| CHANGESETS_GITHUB_TOKEN \|\| GITHUB_TOKEN(权威名 + 旧名兼容)
  2. docsnpm-publish.md 对齐 SFMC_GITHUB_TOKEN
  3. github-release:缺失态回退复用 listPackagesWithExistingVersionTags
  4. 测试:契约单测;node --test tools/changeset-release.test.mjs → 9 pass
  5. changeset@sfmc-bds/tools patch

未改(仍可接受)

  • OPS:仓库需勾选 Actions「create and approve pull requests」或配置 SFMC_GITHUB_TOKEN(本轮发布因无 pending changeset、直接走 publish,未再触开 Version PR)
  • MINOR:ServiceId 仍含 pack-manager(CLI 路径仍需要)

Test plan

  • node --test tools/changeset-release.test.mjs(9 pass)
  • CI ootb 绿
  • 确认 workflow Secret 表达式含 SFMC_GITHUB_TOKEN 与旧名回退
Open in Web View Automation 

#76 合入后文档/注释仍写 CHANGESETS_GITHUB_TOKEN,与维护者改用的
SFMC_GITHUB_TOKEN 漂移;workflow 同时兼容旧名。github-release 缺失态
回退改为复用 listPackagesWithExistingVersionTags,避免重复 tag -l 扫描。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 25, 2026 05:54
@cursor

cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 5fd5384 into main Jul 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants