Skip to content

fix(release): HEAD~1 tags + trust empty state; ship tools@0.2.0-beta.1 - #76

Merged
Tanya7z merged 4 commits into
mainfrom
cursor/bc-37b792ac-0140-4bba-b234-a0fa880486f2-ffaf
Jul 25, 2026
Merged

fix(release): HEAD~1 tags + trust empty state; ship tools@0.2.0-beta.1#76
Tanya7z merged 4 commits into
mainfrom
cursor/bc-37b792ac-0140-4bba-b234-a0fa880486f2-ffaf

Conversation

@cursor

@cursor cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Post-merge review of #73 / #74 on main@2d7f763. ootb succeeded; changeset-release failed because Actions cannot create PRs (repo setting), leaving changeset-release/main without a Version Packages PR.

This PR:

  1. Lands the blocked tools 0.2.0-beta.1 version bump (consumes fix-release-tag-shallow)
  2. Closes residual LSP holes in the release pipeline that #74 left
  3. Documents the Actions “create and approve pull requests” requirement
  4. Aligns remote-controller ROOT with db/qq (project-root.ts)

Review findings → fixes

Severity Principle Issue Fix
OPS BLOCKER GitHub Actions is not permitted to create or approve pull requests Docs in docs/dev/npm-publish.md; this PR carries the Version Packages content so publish can proceed after merge
MAJOR LSP CI forced --from-existing despite fetch-depth: 0, re-listing all existing name@version tags tag-packages only uses --from-existing / SFMC_TAG_FROM_EXISTING=1; default = HEAD~1 diff
MAJOR LSP Empty .sfmc-release-tags.json treated as missing → fallback scanned all tags resolveReleaseTagEntries: trust present state including tags: []
MAJOR DRY push / gh-release duplicated “trust state?” logic Shared resolveReleaseTagEntries
MINOR DIP/DRY remote-controller inlined ROOT project-root.ts

Tests

  • node --test tools/changeset-release.test.mjs — 7 pass (incl. empty-state LSP cases)

Maintainer action (still needed)

Enable Settings → Actions → General → Allow GitHub Actions to create and approve pull requests, or future Version Packages PRs will keep failing the same way.

Residual (not in this PR)

  • MINOR — ServiceId pack-manager still registered
  • MINOR — ootb coverage for eslint-plugin / pack-update
Open in Web View Automation 

cursoragent and others added 3 commits July 25, 2026 05:35
LSP: stop CI auto --from-existing (fetch-depth:0 should version-diff);
empty .sfmc-release-tags.json must not fall back to scanning all tags.
DRY: resolveReleaseTagEntries shared by push / gh-release.

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
… ROOT

Delete applied fix-release-tag-shallow.md; document empty-state/HEAD~1 in
CHANGELOG. Extract remote-controller project-root.ts (align db/qq DIP).

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Wire optional PAT for Version PR when Actions cannot create PRs.
Exclude pre.json consumed ids from listPendingChangesetFiles (pre mode).

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 25, 2026 05:50
@cursor

cursor Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 7d92a08 into main Jul 25, 2026
1 check passed
@Tanya7z
Tanya7z deleted the cursor/bc-37b792ac-0140-4bba-b234-a0fa880486f2-ffaf branch July 25, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants