fix: SOLID hardening after service logs + batch uninstall - #73
Merged
Tanya7z merged 3 commits intoJul 25, 2026
Conversation
- DRY: share resolveDisplayLevel / level+source tag plain text in sfmc logs - LSP: resolveUninstallTargets aborts when any protected pack is selected - DIP: single project-root for db-server and qq-bridge (env/config/log) - LSP: FileSink contract matches sync append (drop unused flags; clarify close) Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Share BDS_TS_PREFIX_RE between stripLogPrefix and getLogLevel so resolveDisplayLevel maps [ts ERROR] lines to error (DRY). Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Restore tracked dist map to pre-review state; rebuild churn was unrelated. Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 25, 2026 05:30
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review of
main@ae55513(unify service file logs, hang-indent, batch packs uninstall). ootb CI on that push was success; this PR patches SOLID issues found in the review.Fixes (by principle)
resolveDisplayLevel+ shared level/source tag plain text forformatLog/logPrefixWidthBDS_TS_PREFIX_REshared bystripLogPrefix/getLogLevelso BDS[ts ERROR]maps correctlyresolveUninstallTargets: any protected pack aborts (single- and multi-id same contract)db-server/qq-bridgeproject-root.tsas sole ROOT; env/config/log consume itFileSink: drop unusedflags; document sync-appendclose()no-opTests
sfmcnpm test: 31 pass (incl.resolveUninstallTargets+resolveDisplayLevel)db-servernpm test: 13 passResidual (not in this PR)
ServiceIdpack-manager still registered