fix(progress): 补齐 #67 后 binder 首帧/非TTY LSP + 恢复 pause 契约测 - #68
Merged
Tanya7z merged 2 commits intoJul 24, 2026
Conversation
#67 重 start 后省略 update，首帧卡在 0；非 TTY logger 写死 0% 忽略 startValue。始终 update + start 尊重 startValue；恢复 pause/resume 测。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 13:14
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Tanya7z
added a commit
that referenced
this pull request
Jul 24, 2026
…848a-ef433640bd8d-211c fix(progress): ProgressHandle.setTotal + 首帧/非TTY DRY（#68 后）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Push
main@dab1ad6（合并 #67）后 ootb success（30094461300）。审查 #67 合入后的进度条残余 SOLID 债并提交补丁。审查（原则标注）
#67的bindByteProgressToBar在start/ 未知→已知重start后不再update→ 首帧卡在 0；非 TTY 收尾若只有一次 finish 回调会丢最终刻度createTerminalProgress.start非 TTY logger 写死进度 0% (0/${total})，忽略startValue（与ProgressHandle.start契约不一致；重 start 修总量时更明显）#67删掉 pause/resume 嵌套契约测，换成无意义 Writable 烟测 → 注册表契约失覆盖改动
bindByteProgressToBar：start/ 重start后始终update（对齐 fix(pack-update): 补齐未知总量进度条 LSP + DRY bindOk/touchBinding #67 前首帧行为 + 非 TTY）createTerminalProgress.start：非 TTY logger 按startValue算百分比pauseAllProgress/resumeAllProgress嵌套测；补齐首帧 update / 非 TTY startValue 断言验证
npm test -w @sfmc-bds/cli（19 pass）npm run typecheck -w @sfmc-bds/sdk未改
ServiceIdpack-manager 注册（主路径已不 spawn）ProgressHandle.setTotal（仍用重 start；有独立 setTotal 时可再收敛）