fix(progress): ProgressHandle.setTotal + 首帧/非TTY DRY(#68 后) - #70
Merged
Tanya7z merged 1 commit intoJul 24, 2026
Merged
Conversation
#68 合入后仍用重 start 改总量,且首帧 start(0) 会在非 TTY 打出虚假 0%。 新增 setTotal;binder 首帧带已下载量;非 TTY 日志单一出口;加强 pause 契约测。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 13:22
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Push
main@f4a6ac2(合并 #68)后 ootb success(30096150517)。审查 #68 合入后的进度条残余 SOLID 债并提交补丁。审查(原则标注)
start冒充改刻度;ProgressHandle缺setTotalstart(total, 0)再update(dl)→ 非 TTY 先打出虚假0%createTerminalProgress的start/update各自拼非 TTY 百分比日志active,未验证内层 resume 不重绘;无意义 Writable 烟测改动
ProgressHandle.setTotal+ binder 未知→已知走setTotal(不再重 start)start(totalMb, dlMb, …),避免虚假 0%emitNonTty(start/update 共用)验证
npm test -w @sfmc-bds/cli(19 pass)npm run typecheck -w @sfmc-bds/sdk未改
ServiceIdpack-manager 注册(主路径已不 spawn)