fix: SEA Node DRY + pack-lifecycle→pack-manager-lib（审查 #56） - #57
Merged
Tanya7z merged 2 commits intoJul 23, 2026
Merged
Conversation
审查 #56 合入后：默认 CI 已统一到 .node-version，但 SEA 仍在 release.yml 与 build-sea.mjs 各写一份 node26。抽出 .node-version-sea 作为 SEA 目标唯一权威；release 用 node-version-file，bundle 读取同文件。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
审查 #56 合入后收敛长期债：world-packs 已同进程 import 库， pack-lifecycle 却仍 spawn CLI 解析 stdout，形成双路径。 - 导出 @sfmc-bds/bds-tools/pack-manager-lib - 抽出 readLevelNameSync（与 async 同契约） - assemble/deploy/enable/disable/permission/list/has/manifest 全部改库调用；CLI 保留为外部薄适配 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 23, 2026 17:08
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Tanya7z
added a commit
that referenced
this pull request
Jul 24, 2026
…a348-eefd3109596b-3e41 fix: BDS 路径 helpers 收敛 Demeter/DRY（审查 #57）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
main@2f2f2e3合入 #56（.node-version统一默认 CI）。ootb 已绿（run30024500502，Node v24.18.0）。本 PR 收敛审查中仍可验证的债。审查（DRY / OCP / DIP / LSP / Demeter）
release.yml写死26，build-sea.mjs写死node26（#56 只统一了烟测 CI）sfmc/world-packs已同进程 import@sfmc-bds/bds-tools/world-packs，pack-lifecycle却仍 spawn CLI 解析 stdout — 双路径readLevelName仅 async，同步调用方被迫走 CLI改动
.node-version-sea=26— SEA 唯一权威；release.yml→node-version-file；build-sea.mjs读取同文件拼node${major}（OCP：与.node-version烟测关注点分离）@sfmc-bds/bds-tools/pack-manager-lib；抽出readLevelNameSyncpack-lifecycle：assemble / deploy / enable / disable / permission / list / has / manifest 全部改库调用；CLI 保留为外部薄适配验证
npm run build --workspaces --if-presentnpm run test --workspace @sfmc-bds/bds-tools（含readLevelNameSync契约）npm run typecheck（bds-tools + cli）未改
check-ootb仍以 ≥22.13 为运行时下限（与 CI pin 24 职责不同）