fix: BDS 路径 helpers 收敛 Demeter/DRY（审查 #57） - #59
Merged
Tanya7z merged 2 commits intoJul 24, 2026
Conversation
#57 已让 pack-lifecycle 直连 pack-manager-lib，但调用方仍硬拼 worlds/config/server.properties 布局。抽出 bdsWorldsDir / worldPackListFile / configPermissionPath 等权威入口， readLevelName 委托 Sync，删掉未使用的 listEnabled* 双轨。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This was referenced Jul 23, 2026
Tanya7z
marked this pull request as ready for review
July 24, 2026 11:11
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
main@3ed3bc6合入 #57（SEA Node DRY + pack-lifecycle→pack-manager-lib）与 #58（tsc7 双轨）。ootb 已绿（run30028138389）。本 PR 收敛审查中仍可验证的 Demeter/DRY 债。审查（DRY / OCP / DIP / LSP / Demeter）
pack-lifecycle/world-packs仍硬拼config/<uuid>/permission.jsonpath.join(bdsRoot, "worlds")泄漏布局world_*_packs.json文件名 ternary 在读写两侧重复readLevelName与 Sync 仍双份 path/exists；deployToBDS局部worldsDir与EnablePackOpts.worldsDir语义冲突listEnabledSapiEntries/listEnabledResourcePackDirs双轨导出改动
pack-manager-lib路径权威：serverPropertiesPath/bdsWorldsDir/bdsWorldLevelDir/worldPackListFile/configPermissionPath/hasConfigPermissioneditWorldPackList+readWorldPackListResult共用worldPackListFilereadLevelName→readLevelNameSync（同契约 LSP）pack-lifecycle/world-packs/cli-pack-manager/server-properties/sfmc packs path全部改走 helpers；删除死导出验证
npm run build --workspaces --if-presentnpm run test --workspace @sfmc-bds/bds-tools（21 pass）npm run typecheck（bds-tools + cli）未改
ServiceIdpack-manager 注册仍保留（外部调试薄适配）