fix(ci): .node-version 统一默认 CI Node(审查 ee7a9f5) - #56
Merged
Tanya7z merged 1 commit intoJul 23, 2026
Conversation
ee7a9f5 将 ootb 升到 Node 24 后,npm-publish 仍钉 22.22 且注释声称与 ootb 对齐。 抽出仓库根 .node-version 作为唯一权威;ootb/npm-publish 经 node-version-file 消费。 release 仍故意用 Node 26(SEA target)。顺带将 checkout/setup-node 升到 v5,消除 Node 20 runtime 弃用告警。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Member
|
i love u |
Tanya7z
marked this pull request as ready for review
July 23, 2026 16:17
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
cursor Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
审查 #56 合入后收敛长期债:world-packs 已同进程 import 库, pack-lifecycle 却仍 spawn CLI 解析 stdout,形成双路径。 - 导出 @sfmc-bds/bds-tools/pack-manager-lib - 抽出 readLevelNameSync(与 async 同契约) - assemble/deploy/enable/disable/permission/list/has/manifest 全部改库调用;CLI 保留为外部薄适配 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
added a commit
that referenced
this pull request
Jul 23, 2026
…a047-cd45ac283a4d-7f71 fix: SEA Node DRY + pack-lifecycle→pack-manager-lib(审查 #56)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
main@ee7a9f5将ootb.yml的node-version从22.22改为24。ootb 已绿(run30024111056,实际v24.18.0),但留下版本权威分叉。审查(DRY / OCP)
npm-publish.yml仍钉22.22,注释却写「与 ootb.yml 对齐」——两个 workflow 各有一份 Node 版本24事实不符actions/checkout@v4/setup-node@v4触发 Node 20 runtime 弃用告警改动
.node-version(24)作为默认 CI Node 唯一权威ootb.yml/npm-publish.yml改用node-version-file: .node-versionrelease.yml故意独立:继续 Node 26(SEAbuild-sea.mjstarget),注释标明不读.node-version(OCP:发布产物与烟测 CI 关注点分离)checkout/setup-node升到@v5(Node 24 action runtime)验证
npm-run-all2@9的^24.15.0)未改(范围外)