Skip to content

fix(ci): .node-version 统一默认 CI Node(审查 ee7a9f5) - #56

Merged
Tanya7z merged 1 commit into
mainfrom
cursor/bc-edc3cb71-d49f-4397-ae11-ae511b94a581-cc9a
Jul 23, 2026
Merged

fix(ci): .node-version 统一默认 CI Node(审查 ee7a9f5)#56
Tanya7z merged 1 commit into
mainfrom
cursor/bc-edc3cb71-d49f-4397-ae11-ae511b94a581-cc9a

Conversation

@cursor

@cursor cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

背景

main@ee7a9f5ootb.ymlnode-version22.22 改为 24。ootb 已绿(run 30024111056,实际 v24.18.0),但留下版本权威分叉。

审查(DRY / OCP)

级别 原则 问题
MAJOR DRY npm-publish.yml 仍钉 22.22,注释却写「与 ootb.yml 对齐」——两个 workflow 各有一份 Node 版本
MINOR DRY ootb 注释仍写「22.22 同时满足两者」,与 24 事实不符
MINOR Node 24 runner 上 actions/checkout@v4 / setup-node@v4 触发 Node 20 runtime 弃用告警

改动

  • 新增仓库根 .node-version24)作为默认 CI Node 唯一权威
  • ootb.yml / npm-publish.yml 改用 node-version-file: .node-version
  • release.yml 故意独立:继续 Node 26(SEA build-sea.mjs target),注释标明不读 .node-version(OCP:发布产物与烟测 CI 关注点分离)
  • 三份 workflow 的 checkout / setup-node 升到 @v5(Node 24 action runtime)

验证

  • 触发 push 的 ootb 已在 Node 24.18.0 上绿(满足 npm-run-all2@9^24.15.0
  • 本 PR 的 ootb check 应继续绿

未改(范围外)

Open in Web View Automation 

ee7a9f5 将 ootb 升到 Node 24 后,npm-publish 仍钉 22.22 且注释声称与 ootb 对齐。
抽出仓库根 .node-version 作为唯一权威;ootb/npm-publish 经 node-version-file 消费。
release 仍故意用 Node 26(SEA target)。顺带将 checkout/setup-node 升到 v5,消除 Node 20 runtime 弃用告警。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z

Tanya7z commented Jul 23, 2026

Copy link
Copy Markdown
Member

i love u

@Tanya7z
Tanya7z marked this pull request as ready for review July 23, 2026 16:17
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 2f2f2e3 into main Jul 23, 2026
1 check passed
cursor Bot pushed a commit that referenced this pull request Jul 23, 2026
审查 #56 合入后收敛长期债:world-packs 已同进程 import 库,
pack-lifecycle 却仍 spawn CLI 解析 stdout,形成双路径。

- 导出 @sfmc-bds/bds-tools/pack-manager-lib
- 抽出 readLevelNameSync(与 async 同契约)
- assemble/deploy/enable/disable/permission/list/has/manifest
  全部改库调用;CLI 保留为外部薄适配

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z added a commit that referenced this pull request Jul 23, 2026
…a047-cd45ac283a4d-7f71

fix: SEA Node DRY + pack-lifecycle→pack-manager-lib(审查 #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants