fix(ci): eslint-plugin configs 漏交 + 移除残缺 land 恢复 ootb - #48
Merged
Tanya7z merged 1 commit intoJul 23, 2026
Conversation
BLOCKER 1 — DRY/.gitignore：configs/ 误伤 **/configs/**， @sfmc-bds/eslint-plugin 的 src/configs/recommended.ts 未入库 → TS2307。 改为 /configs/，补回规则注册表与 flat config 工厂。 BLOCKER 2 — DIP/LSP：主仓 packages/land 依赖未安装的 feature-economy， check-modules 与 loadManifestV2 启动失败。按「业务模块外置、开箱仅 afk」 移除残缺 land，恢复 catalog/lock；land/economy 经 fetch-module 安装。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 23, 2026 11:13
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
cursor Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
#48 已修复 eslint-plugin configs 漏交与残缺 land，但 package-lock 仍保留 modules/packages/land 与旁路 sfmc-modules/economy 包条目 （标记 extraneous）。彻底删除，避免假依赖信号（DRY）。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
触发
ootb在main@25f6d23/3e6f0e8失败（runs 30001583240、30001567889）。审查（DRY · OCP · DIP · LSP · Demeter）
.gitignore写configs/误伤**/configs/**，@sfmc-bds/eslint-plugin的src/configs/recommended.ts从未入库 → CITS2307packages/land声明requires: feature-economy且services.requireseconomy.*，但 economy 未安装 →check-modules与loadManifestV2启动失败Plugin.rules与@typescript-eslintRuleModule类型不重叠（运行时兼容，需断言）补丁
.gitignore：configs/→/configs/modules/sdk/@sfmc-eslint-plugin/src/configs/recommended.ts（及 dist）plugin as unknown as ESLint.Plugin对齐类型边界modules/packages/land，恢复 afk-onlycatalog.json/module-lock.json；清理 lock 中对旁路sfmc-modules/economy的链接验证