Skip to content

fix(ci): 清理 land/economy lock 残留 + eslint-plugin dist 对齐 SDK - #50

Merged
Tanya7z merged 1 commit into
mainfrom
cursor/bc-028fe66b-4c09-4203-8c71-16f95222cfd3-07a5
Jul 23, 2026
Merged

fix(ci): 清理 land/economy lock 残留 + eslint-plugin dist 对齐 SDK#50
Tanya7z merged 1 commit into
mainfrom
cursor/bc-028fe66b-4c09-4203-8c71-16f95222cfd3-07a5

Conversation

@cursor

@cursor cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

背景

ootb 在 3e6f0e8/25f6d23@sfmc-eslint-plugin 漏交 configs/recommended.ts(根因:.gitignoreconfigs/ 误伤 **/configs/**)与残缺 in-repo land 失败。#48 已合并修好主路径;本 PR 是跟进清理。

审查(DRY · OCP · DIP · LSP · Demeter)

级别 原则 问题
MAJOR DRY package-lock 仍留 modules/packages/land 与旁路 sfmc-modules/economy extraneous 条目
MAJOR DIP @sfmc-eslint-plugin/dist 入库,与 @sfmc-sdk「源码权威、构建产物不入库」不一致,易再提交残缺 dist
MAJOR DRY 四条规则测试重复 RuleTester/node:test 样板
MINOR DIP npm run lint 未先 build plugin,依赖可能不存在的 dist

补丁

  1. package-lock.json 删除 land/economy 残留(覆盖 fix(ci): eslint-plugin configs 漏交 + 移除残缺 land(post-#47 main) #49 的 lock 清理)
  2. .gitignore 增加 modules/sdk/@sfmc-eslint-plugin/dist/,并卸载已跟踪 dist
  3. 抽取 createRuleTester(),四条测试共用
  4. linteslint-plugin:build && eslint .

#49 关系

验证

npm run build --workspaces --if-present   # PASS
SFMC_ROOT=$PWD node tools/check-ootb.mjs # 12/12 PASS
Open in Web View Automation 

- package-lock 删除已移除的 packages/land 与旁路 economy 条目(DRY)
- gitignore @sfmc-eslint-plugin/dist,与 @sfmc-sdk 一致,避免再提交残缺产物
- RuleTester 样板抽到 createRuleTester(DRY)
- lint 脚本先 build eslint-plugin,保证 flat config 可解析

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@Tanya7z
Tanya7z marked this pull request as ready for review July 23, 2026 11:19
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 6db88da into main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants