fix(ci): sdk contracts 精简后补迁 Economy*Row — 修复 ootb 构建 - #47
Merged
Tanya7z merged 2 commits intoJul 23, 2026
Conversation
sdk@0990780 精简 contracts 后 db-server 仍从 @sfmc-bds/sdk/contracts 导入已删除的 EconomyAccountRow / EconomyTransactionRow,导致 ootb Build all workspaces 的 tsc --emitDeclarationOnly 失败。 按契约精简意图,业务行类型由经济域自行维护;同步修正 SDK README。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
5 tasks
Tanya7z
marked this pull request as ready for review
July 23, 2026 11:09
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Tanya7z
added a commit
that referenced
this pull request
Jul 23, 2026
…b7f2-1adb835cb742-f52d fix(ci): eslint-plugin configs 漏交 + 移除残缺 land(post-#47 main)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


背景
main@
0990780(sdk 共享契约精简)删除了@sfmc-bds/sdk/contracts中的 economy/land/chat/coop 等业务域类型,但db-server/src/domain/economy.ts仍从该入口导入EconomyAccountRow/EconomyTransactionRow。ootb
Build all workspaces在tsc --emitDeclarationOnly阶段失败:失败 run:29991000606
审查(DRY · OCP · DIP · LSP · Demeter)
0990780将业务域类型交还模块内部维护是正确方向;本补丁把权威定义落在domain/economy.tsEconomyTransactionRow.idempotency_key与sfmc_economy_transactions表列不完全对齐(历史债,本 PR 不改行为)变更
db-server/src/domain/economy.ts本地定义并导出EconomyAccountRow/EconomyTransactionRow(与删除前契约一致)@sfmc-bds/sdk/contracts的经济类型导入@sfmc-bds/sdkREADME 对 contracts 范围的描述验证