fix(solid@1c9c24d): orderBy LSP + publish workspaces 门禁 + HttpDB 按请求鉴权 - #29
Merged
Tanya7z merged 2 commits intoJul 22, 2026
Merged
Conversation
SDK OrderBy 用 field，tx-runner 只认 col，带 orderBy 的 query 会炸。 抽取 normalizeOrderBy 兼收 field/col 与数组。 清单包必须落在 root workspaces，否则 npm -w 再现 ba65eb9 tools 失败； resolve-npm-publish-tag 与 check-ootb 共用断言(DRY)。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
模块 db/config/service 不再写进程级 authToken，避免与 ConfigManager 互相覆盖(DIP)。db.tx 录制期 query/get 显式抛错，不再返回 []/null stub(LSP)； call 仍可入队但返回值不可用。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 22, 2026 14:24
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Push
main@1c9c24d（合入 #28）后 ootb 已绿。审查仍发现可验证 SOLID 问题；@sfmc-bds/tools@v0.1.0tag 仍指向缺 workspaces 的ba65eb9，同类失败需门禁防再发。审查结论（DRY / OCP / DIP / LSP / Demeter）
OrderBy.fieldvs tx-runnercolnormalizeOrderBy互通 + 数组db.txquery/get 返回[]/nullstubtx_interactive_requiredHttpDB.authTokenstaticauthToken{success}方言修复
db-server/src/lib/order-by.ts+ tx-runner 使用assertPublishPackageInWorkspaces（tools lib）typedRequest(..., { authToken })；db/config/service 各自持有 tokendb.tx：query/get 禁止假读回；call 仍可入队验证
db-servernpm test：8/8SFMC_ROOT=$PWD node tools/check-ootb.mjs：10/10（含新 workspaces 项）合入后操作
@sfmc-bds/tools@v0.1.0：在含 workspaces 的 main 上workflow_dispatch指定该 tag（checkout 默认分支即可），或挪 tag / 发 0.1.1