fix(push@bc7f01c): npm-publish 收窄 + SOLID（Money/信封/TxResponse/OCP） - #23
Merged
Tanya7z merged 2 commits intoJul 22, 2026
Merged
Conversation
临时 tags:"**" 会误触 SEA v*；改回 **sfmc-bds/**。 resolve 脚本探测 registry，already_published 时跳过 publish，避免 E403。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
BLOCKER/LSP: Money 不再打已删 /api/sfmc/economy/*，改 economy.account.*。
DRY/LSP: jsonV2Fail 统一 v2 未授权/失败为 {ok:false}。
LSP: SAPI TxResponse.steps → results 与 server 对齐。
OCP: BUILTIN_SERVICE_PLUGINS 扩展点，index 不再硬编码 economy if。
Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 22, 2026 13:12
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
审查 main push
ee8f196..bc7f01c（临时tags: "**"+ merge #22）后的补丁。CI / wf
npm-publish临时tags: ["**"]会误触 SEAv*；改回**sfmc-bds/**（保留跨/）。resolve-npm-publish-tag.mjs探测 registry，写already_published；已发布则跳过 build/publish，避免 workflow_dispatch 重跑 E403（run 29920691408）。SOLID（DRY · OCP · DIP · LSP · Demeter）
Money改走economy.account.get/credit/debit，不再打已删/api/sfmc/economy/*jsonV2Fail统一 v2 未授权/失败为{ok:false}（index / db / module-config / service）TxResponse.steps→results，与 servertx-runner对齐BUILTIN_SERVICE_PLUGINS+registerEnabledBuiltinServices，index 不再硬编码 economy if仍未修（架构债，非本 PR 范围）
authToken+ HOST/PORT 硬编码db.txrecorder 仍返回 stub，不消费 serverresults（需协议改造）success方言（legacy）Test plan
node tools/resolve-npm-publish-tag.mjs+@sfmc-bds/sdk@v0.1.0→already_published=truePUBLISH_TAG=v1.0.0→ exit 1（拒绝 SEA 形 tag）npm run build --workspace @sfmc-bds/sdk/@sfmc-bds/db-serverSFMC_ROOT=$PWD node tools/check-ootb.mjs→ 10/10