Skip to content

fix(ui): don't wipe the current project when a stale fetch rejects #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavidelizade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): don't wipe the current project when a stale fetch rejects #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/web/src/components/layout/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ export function PageHeader() {
if (!cancelled && list) setProjects(list);
})
.catch(() => {
if (!cancelled) setWorkspace(null);
if (cancelled) return;
setWorkspace(null);
setProjects([]);
});
return () => {
Expand All @@ -98,7 +99,8 @@ export function PageHeader() {
if (!cancelled && Array.isArray(issues)) setProjectIssueCount(issues.length);
})
.catch(() => {
if (!cancelled) setProject(null);
if (cancelled) return;
setProject(null);
setProjectIssueCount(0);
});
return () => {
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/pages/IssueListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,10 @@ export function IssueListPage() {
setMembers(mem ?? []);
})
.catch(() => {
if (!cancelled) setWorkspace(null);
// Guard the whole reset: a stale request rejecting after the user
// switched projects must not wipe the newly-loaded project's data.
if (cancelled) return;
setWorkspace(null);
setProject(null);
setProjects([]);
setIssues([]);
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/pages/ProjectsListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ export function ProjectsListPage() {
if (!cancelled && list) setAllProjects(list);
})
.catch(() => {
if (!cancelled) setWorkspace(null);
if (cancelled) return;
setWorkspace(null);
setAllProjects([]);
})
.finally(() => {
Expand Down
Loading