fix(ui): don't wipe the current project when a stale fetch rejects#321
fix(ui): don't wipe the current project when a stale fetch rejects#321cavidelizade wants to merge 1 commit into
Conversation
The issue-list aggregate load guarded only the first setter in its .catch; the remaining setters ran unconditionally. Opening project A then quickly switching to B, if A's request rejected after B loaded, cleared B's issues/states/labels/cycles/modules and showed an empty page for a valid project. Guard the whole catch body with the cancelled flag. Same one-line guard applied to ProjectsListPage and the two PageHeader loaders. Closes Devlaner#316 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@martian56 #316 — on the issue list, a background request rejecting after you'd already switched projects would blank out the project you were looking at (only the first setter was guarded). Guarded the whole catch across the list page and the two other spots with the same pattern. Green, no open comments. Good to merge? |
Summary
The issue-list aggregate load guarded only the first setter in its
.catch; the rest ran unconditionally. Opening project A then quickly switching to B — if A's request rejected after B had loaded — cleared B's issues/states/labels/cycles/modules and left an empty page for a perfectly valid project.Linked issues
Closes #316
Type of change
fix:)Surface
apps/web/)What changed
IssueListPage: replacedif (!cancelled) setWorkspace(null)(with 8 unguarded setters after it) with an earlyif (cancelled) return;so the whole reset is skipped for a stale request.ProjectsListPageand both loaders inPageHeader, which had the identical partial-guard pattern.Why this approach
The
cancelledflag already exists (flipped in each effect's cleanup); it was just applied to one line instead of the block. Early-returning the entire catch is the smallest correct fix and matches how the.then/.finallyhandlers in the same effects already guard.Test plan
npm run typecheck+npm run lintpassAI assistance
Claude Code (Opus 4.8)— commits carry aCo-Authored-By:trailer