Skip to content

chore: remove internal service names and tracker ids from public source #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomershlasky merged 1 commit into from
Oct 7, 2026
Merged

chore: remove internal service names and tracker ids from public source #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk/src/realtime/config-realtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const REALTIME_CONFIG = {
/** Close code for a policy termination. */
terminalCloseCode: 1008,
/**
* The bouncer's concurrent-session refusal: an `error` message carrying
* The server's concurrent-session refusal: an `error` message carrying
* `errorText`, then close `closeCode` with `closeReason`. Retrying it only
* takes a slot from whoever is next in line. 1013 with any other reason
* ("Try Again Later": upstream at capacity) is transient and still retries.
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tests/e2e-realtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe.concurrent("Realtime E2E Tests", { timeout: TIMEOUT, retry: 2 }, () =>
}

// POST /v1/files + image_ref via realtime. Uses lucy-2.1 to actually exercise
// upstream forwarding through the bouncer's image_ref prologue.
// upstream forwarding through the server's image_ref prologue.
describe("Files API + image_ref", () => {
async function pngBlob(width: number, height: number, color = "#3070C0"): Promise<Blob> {
const canvas = document.createElement("canvas");
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/tests/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const OUTPUT_DIR = join(__dirname, "e2e-output");
const VIDEO_FIXTURE = join(__dirname, "fixtures", "video.mp4");
const IMAGE_FIXTURE = join(__dirname, "fixtures", "image.png");
// Try-on models take the GARMENT as reference_image; a non-garment reference (the dogs above) makes
// the try-on models undress the subject and the output fails moderation (PLA-808, PLA-817).
// the try-on models undress the subject and the output fails moderation.
const GARMENT_FIXTURE = join(__dirname, "fixtures", "garment.png");

const TIMEOUT = 5 * 60 * 1000; // 5 minutes
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/tests/realtime.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2027,8 +2027,8 @@ describe("StreamSession startup orchestration", () => {
expect(errors).toEqual([]);
});

it("does not retry the bouncer's session-limit refusal during the handshake", async () => {
// The bouncer sends an `error` message, then closes 1013 "Session Limit Reached". Each
it("does not retry the server's session-limit refusal during the handshake", async () => {
// The server sends an `error` message, then closes 1013 "Session Limit Reached". Each
// retry would be a fresh dial that takes a freed slot ahead of the app's own queue.
const { session, ws, ended, connectPromise } = await openHandshake({ initialImage: "queued-garment" });

Expand Down
Loading