Repository navigation
chore: remove internal service names and tracker ids from public source - #218
Merged
Merged
Conversation
This repo is public. Four comments named an internal service by its internal codename, referenced an internal tracker id, or both. None of them are needed to understand the code — each is reworded to "the server" or drops the id while keeping the explanation. - src/realtime/config-realtime.ts: session-limit refusal comment - tests/realtime.unit.test.ts: test name + comment for the same behavior - tests/e2e-realtime.test.ts: image_ref prologue comment - tests/e2e.test.ts: drops two internal ticket ids from the garment-fixture note No behavior change. The renamed test is internal to this file.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This repo is public, and four comments carried internal vocabulary: an internal service codename in three of them, and a pair of internal tracker ids in the fourth. None of it is needed to understand the code.
src/realtime/config-realtime.tstests/realtime.unit.test.tstests/e2e-realtime.test.tsimage_refprologue comment now says "the server"tests/e2e.test.tsFound while reviewing #217 for the same problem. These are pre-existing and unrelated to that change, so they are split out here to merge independently.
Sibling scrubs for the same class of issue: DecartAI/decart-ios#48 and DecartAI/decart-android#33.
Verification
pnpm --filter @decartai/sdk test— 374 passedpnpm --filter @decartai/sdk format:check— cleanComments and one test name only; no behavior change. The renamed test is local to its file.