Repository navigation
Connect the dd-openfeature SDK to the agent - #12844
Draft
PerfectSlayer wants to merge 3 commits into
Draft
PerfectSlayer wants to merge 3 commits into
PerfectSlayer wants to merge 3 commits into
Conversation
This was referenced Oct 13, 2026
PerfectSlayer
added this pull request to stack #12847
October 13, 2026 07:19
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 09:03
cdbf2c1 to
95be4d3
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 09:28
95be4d3 to
128b8ba
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 10:07
128b8ba to
9027902
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 10:28
9027902 to
a6f0035
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 10:59
a6f0035 to
7db60be
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 13, 2026 13:50
7db60be to
e00532b
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 05:34
e00532b to
e4e4a30
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 06:03
e4e4a30 to
d4e4bbf
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 06:16
d4e4bbf to
fd5f72b
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 07:11
fd5f72b to
ded4413
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 08:07
ded4413 to
50e4ae5
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 08:38
50e4ae5 to
fdd1b89
Compare
Ship the standalone dd-openfeature SDK in place of the agent-coupled provider. The new dd-openfeature-connector instrumentation detects the SDK and plugs the agent backend in through the FeatureFlaggingGateway: Remote Configuration documents, the event platform proxy, telemetry health metrics and span enrichment. The agent now forwards raw configuration documents and event payloads, UFC parsing, evaluation and event batching stay in the SDK. Remove the feature-flagging-api module and the agent-side agentless configuration and event code the SDK now owns. Keep datadog.trace.api.openfeature.Provider as a deprecated alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Move the Feature Flags configuration keys to dd-trace-api next to the other products. The module has no remaining use since the configuration resolution moved to InstrumenterConfig. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Return the configuration source enum from Config now that the previous feature flagging code is gone, and drop the source value constants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PerfectSlayer
force-pushed
the
bbujon/ffe-agent-connector
branch
from
October 14, 2026 08:43
fdd1b89 to
bfba459
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Ships the standalone
dd-openfeatureSDK in place of the agent-coupled provider:dd-openfeature-connectorinstrumentation: detects the SDK and plugs the agent backend in through the bootstrapFeatureFlaggingGateway(Remote Configuration documents, event platform proxy, telemetry health metrics, span enrichment).feature-flagging-lib) now forwards raw configuration documents and event payloads (FeatureFlagsBackend,EventProxy).feature-flagging-apiand the agent-side agentless configuration/event code now owned by the SDK, plus their config keys. Removes thefeature-flagging-configmodule, its keys moving todd-trace-api.:dd-openfeatureascom.datadoghq:dd-openfeature; keepsdatadog.trace.api.openfeature.Provideras a deprecated alias.dd-openfeaturejar.Motivation
The SDK must not share dd-trace-java internals, and SDK (customer build time) and agent (SSI runtime) versions must be able to differ (APMLP-1512). See
dd-openfeature/README.md.Additional Notes
Most of the diff (~17k lines) deletes agent-side code and tests that now live in the
dd-openfeatureSDK (#12840–#12843). Review closely the new connector instrumentation,FeatureFlaggingGateway,FeatureFlagsBackend,EventProxy,RemoteConfigServiceImplandFeatureFlaggingSystem; the rest is mechanical or deletions.New files
dd-openfeature-connector/build.gradlejava11source set compiled against:dd-openfeature(compileOnly). TODO: add a muzzle directive once the SDK is publishedDDOpenFeatureInstrumentationInstrumenterModule("openfeature")for theFEATURE_FLAGStarget system, instrumentsConnectors.detect()DetectConnectorAdviceJavaAgentConnector.connect(fallback)JavaAgentConnectorConnectorbacked byFeatureFlaggingGateway.backend(), falls back to the SDK default without backendAgentConfigurationSource,AgentEventProxy,AgentHealthMetrics,AgentSpanEnricherBackend.AgentEventProxythrowsEventProxyUnavailableExceptionon definitive rejection so the SDK switches to direct intakeDDOpenFeatureInstrumentationTest,…DisabledForkedTestConfigurationResolutionParityTestInstrumenterConfigand SDKSettingsmust resolve enablement and source identicallyFeatureFlagsBackendFeatureFlaggingGateway.Backend: settings fromConfig(agent defaults for API key, site, env, service, version; others fromconfigProvider()), lazyRemoteConfigServiceImpl, event proxy delegation, health metrics throughCoreMetricCollector, span enrichment throughSpanEnrichmentWriter.start()registers RC early only for theremote_configsourceEventProxyNEVER_RETRYwhen the SDK can fall back to direct intake.ConnectException/ 403 / 404 / 405 mean unavailable, otherIOExceptions are rethrownFeatureFlagsBackendTest,EventProxyTestdd-openfeature/README.mddatadog/trace/api/openfeature/Provider+ProviderTest@Deprecatedalias ofcom.datadog.openfeature.Provider(andOptions) for source compatibilitySignificant changes
FeatureFlaggingGatewayBackendwith JDK-only types:setting,isRemoteConfigAvailable,subscribeRemoteConfig(Consumer<byte[]>),isEventProxyAvailable,postEvent(route, json),count,enrichSerialId,enrichRuntimeDefault. Config / activation / exposure / span enrichment listeners, cached configuration, flag evaluation writer and enqueue toggle removedRemoteConfigServiceImplFFE_FLAGSdocuments (nullon removal) to subscribers, replays the current one to late subscribers. Idempotentstart()/close()SpanEnrichmentWriterserialId(...)/runtimeDefault(...)called byFeatureFlagsBackendFeatureFlaggingSystemFeatureFlagsBackend. Agentless activation, writers, kill switch and source factory moved to the SDKFeatureFlagEventTypelogNameremovedConfig,ConfigDefaults,ConfigTestFeatureFlaggingSourceenum. Agentless base URL, poll interval and request timeout removed; the SDKSettingsreads and validates them, still resolvable from agent config throughBackend.setting()FeatureFlaggingConfigfeature-flagging-configtodd-trace-api; span enrichment, evaluation counts and agentless keys removed (owned by the SDK)dd-openfeature/build.gradle.ktscom.datadoghq:dd-openfeature),Automatic-Module-Name, Java 11 javadoc,compareToReferenceJardisabledRemoteConfigServiceImplTest,SpanEnrichmentWriterTest,FeatureFlaggingSystemTest,FeatureFlaggingGatewayTestMechanical changes
run-system-tests.yaml,.gitlab-ci.yml: build:dd-openfeature:jarso system tests use the matching SDKsettings.gradle.kts: dropsfeature-flagging-api, includesdd-openfeature-connector.github/CODEOWNERS: adds/dd-java-agent/instrumentation/datadog/openfeature/metadata/agent-jar-checks.properties: adds theopenfeatureintegrationmetadata/supported-configurations.json: addsDD_TRACE_OPENFEATURE_ENABLEDand aliasesfeature-flagging-{lib,bootstrap,agent}builds: drop unused dependencies (Moshi, JCTools, dd-trace-core, JMH…) and coverage exclusions:dd-openfeaturejar andcom.datadog.openfeature.ProviderDeleted files (81 files, moved to the SDK)
feature-flagging-apimodule (Provider, DDEvaluator, hooks, metrics, benchmark, tests, README, build)com.datadog.openfeature.*(#12843)feature-flagging-configmoduledd-trace-apiFeatureFlaggingConfig, resolution inInstrumenterConfig(#12845)SpanEnrichmentGateSettings(#12841)ufc/v1/*+ParsedSemverTestinternal/ufc(#12840)exposure/*,flagevaluation/*internal/exposure,internal/flagevaluation(#12842)SpanEnrichmentEvent+ testBackend.enrichSerialId/enrichRuntimeDefaultand the SDKSpanEnricherSPIUniversalFlagConfigParser,JsonApiUfcResponseParser+ testsinternal/ufc/UniversalFlagConfigParser(#12840)AgentlessConfigurationSource,AgentlessFeatureFlagBackendApi,ConfigurationSourceService+ testsinternal/delivery(#12841)FeatureFlagEvpPublisher,FeatureFlagBackendApiFactory,FeatureFlagEvpContext+ testsFallbackTransport,DirectIntakeTransport(#12841); agent proxy part is nowEventProxyremote-config/*.jsonfixturesdd-openfeature(#12842, #12840)Stack
The full change is in #12709. It was split into this stack to ease the review.
Jira ticket: APMLP-1512
🤖 Generated with Claude Code