Repository navigation
Add dd-openfeature SDK settings and configuration delivery - #12841
Draft
PerfectSlayer wants to merge 2 commits into
Draft
PerfectSlayer wants to merge 2 commits into
PerfectSlayer wants to merge 2 commits into
Conversation
This was referenced Oct 13, 2026
PerfectSlayer
added this pull request to stack #12847
October 13, 2026 07:19
Contributor
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
4 times, most recently
from
October 13, 2026 10:27
656cc15 to
ec1fa25
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
2 times, most recently
from
October 13, 2026 13:49
ac0d5b6 to
f5c7297
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
from
October 14, 2026 05:32
f5c7297 to
bb47356
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
from
October 14, 2026 06:01
bb47356 to
3eeebb6
Compare
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
from
October 14, 2026 06:14
3eeebb6 to
62ea31f
Compare
Add the SDK settings, the connector SPI the agent can implement, the agentless configuration delivery from the CDN and the direct intake event transport. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Parse the Feature Flags configuration source like the agent enum config parsing: case insensitive, with no trimming of surrounding spaces, so the SDK and the agent keep resolving the same configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PerfectSlayer
force-pushed
the
bbujon/ffe-sdk-infra
branch
from
October 14, 2026 07:08
62ea31f to
f411f22
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds to the
dd-openfeatureSDK:internal/config: SDK settings (agent config when attached, thendd.system properties, then env vars)internal/connector: the SPI the agent can implement (configuration source, event transport, health metrics, span enricher)internal/delivery: agentless configuration polling from the Datadog CDN, direct intake event transport, fallback transport, retriesMotivation
Lets the SDK work without the agent (APMLP-1512). The connector SPI is the only contract crossing SDK and agent versions.
Additional Notes
All SDK files are new code: none is a straight move from master. Review carefully the delivery classes ported from
feature-flagging-lib: their HTTP stack moved from OkHttp / the agentcommunicationmodule to the JDK 11HttpClient, with retries, gzip and headers rewritten.New files (no master equivalent)
internal/connector/Connector,Connectors,NoConnectorConnectors.detect()returnsNONEand is instrumented by the agentinternal/connector/ConfigurationSourcebyte[]subscription (null= configuration removed)internal/connector/EventTransport,EventProxyUnavailableExceptionpost(route, json)transport; the exception signals a definitive proxy rejection, triggering the fallbackinternal/connector/HealthMetrics,SpanEnricherNOOPdefaultsinternal/EventQueuempscBlockingConsumerArrayQueueinternal/JsonWritinginternal/RuntimeServicesdd-openfeature-<role>threads and health counter wrapper, replacesAgentThreadFactoryinternal/delivery/GzipContent-Encoding: gzip, which the JDK client does not dointernal/delivery/DirectIntakeTransportBackendApiFactory.createDirectIntakeApi. Same headers and 5 retries with 100 ms × 2 backoff. Differences: noX-RateLimit-Resethandling, 408 retried, no compression, fixed 10 s timeout, random trace id,create()returnsnullwithout API key (master threwFatalAgentMisconfigurationError)EventQueueTest,DirectIntakeTransportTest,JsonReading,LocalHttpServer,config/TestSettingsLocalHttpServeris a JDKHttpServerreplaying scripted responsesDerived from master with significant changes
delivery/CdnConfigurationSourceAgentlessConfigurationSourceHttpClient(redirects disabled);UfcHttpClient/AgentlessRetryPolicylayers replaced byRetries. Lifecycle, ETag, last-known-good, 3-attempt retry and jittered backoff kept. Differences: gzip requested and decoded explicitly; configuration pushed to aConsumerinstead of the gateway; API key sent whenever no custom base URL is set (master also checked https and the CDN host);close()interrupts the polling thread without cancelling the in-flight call; inline 5 min log throttle replacesRatelimitedLoggerdelivery/RetriesAgentlessRetryPolicy+OkHttpUtils.sendWithRetriesIOExceptionand 408 / 429 / 5xx, caller-supplied attempts, delays, sleeper and cancellation. NoX-RateLimit-Resetsupportdelivery/FallbackTransportAgentlessFeatureFlagBackendApiEventProxyUnavailableException) instead of classified here (ConnectException, 403 / 404 / 405)delivery/RemoteConfigurationServiceRemoteConfigServiceImplConfigurationSourceinstead ofConfigurationPoller; parses raw UFC bytes in the SDK, malformed payloads logged at debugdelivery/HeadersOkHttpUtils.prepareRequestDatadog-Meta-Lang*, addsDatadog-Meta-Tracer-Version(SDK version), drops container / entity id headersConfigurationServiceConfigurationSourceServiceinit()→start(Consumer<ServerConfiguration>),AutoCloseableconfig/SettingsFeatureFlaggingConfig+Configfeature flag settingsdd.*system property,DD_*env var. Same source resolution semantics, plus API key, site, env, service, version, span enrichment, evaluation counts. Differences: no legacy toggle deprecation warning, unsupported source disables with a warning, invalid booleans readfalse, invalid / non-positive ints fall back to defaultsconfig/SdkVersioncommunicationTracerVersion/dd-openfeature.versionwritten by theversion-fileplugin, strips the git hash suffixCdnConfigurationSourceTestAgentlessConfigurationSourceTestLocalHttpServer. Reduced coverage (~28 vs ~50 cases): in-flight cancellation, request timeout, overlapping polls, repeated init and API key stripping for http / unexpected hosts not portedFallbackTransportTestAgentlessFeatureFlagBackendApiTestSettingsTestFeatureFlaggingConfigTestShared files
dd-openfeature/build.gradle.kts: appliesdd-trace-java.version-file, generating the version resource read bySdkVersiondd-openfeature/gradle.lockfile: regeneratedStack
The full change is in #12709. It was split into this stack to ease the review.
Jira ticket: APMLP-1512
🤖 Generated with Claude Code