Repository navigation
Refactor span tag processing API - #12808
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
87e65c0 to
4042930
Compare
There was a problem hiding this comment.
More details
The serializer options preserve existing link, event, and baggage handling, including root propagation tags on the first span of each chunk and own propagation tags for independent serialization.
🤖 Bits Code Review · Commit 4042930
4042930 to
3bf09db
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
There was a problem hiding this comment.
More details
The new option flags preserve the previous propagation-tag choices at serialization call sites. Validation was limited to static analysis; tests and production behavior were not exercised.
🤖 Bits Code Review · Commit 4042930
What Does This Do
This PR replaces the four
CoreSpan.processTagsAndBaggage*variants with a single method taking anintof options:STRUCTURED_LINKS_dd.span_linkstagSTRUCTURED_EVENTSeventstagOWN_PROPAGATION_TAGSROOT_PROPAGATION_TAGSMotivation
Simplify API and make it more explicit:
DDSpanhad 4 overrides andDDSpanContext5 methods, built from combinations of booleans. Each new serialization need meant two more overloads. They are now a single method each.PojoSpan,SimpleSpan,CountingPojoSpan) override a single method.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
🤖 Generated with Claude Code