Repository navigation
Add span event matcher to JUnit trace assertions - #12810
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3515e494d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
Looks much better than ugly strings with JSONs!
2a6eeaf to
efd35e6
Compare
There was a problem hiding this comment.
More details
The event matcher and migrated OpenTelemetry assertions align with structured span data. Static review found that the metadata-processing flags preserve existing serializer behavior.
🤖 Bits Code Review · Commit efd35e6
efd35e6 to
4f318a7
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.
The expected merge time in
|
85be893
into
master
What Does This Do
Adds a
SpanEventMatcherto the JUnit trace assertions, mirroringSpanLinkMatcher:event(name)matches an event that has no attributes and a time within the span start and end times..time(timestamp, unit)and.attributes(Map)replace these defaults.span().events(...)expects the same number of events, in the same order, likelinks(...).defaultTags()accepts theeventstag, as it already does for_dd.span_links.OpenTelemetry14Testnow asserts structured events and links instead of decoding the JSON of theeventsand_dd.span_linkstags. As a result, thejsonasserttest dependency is removed.Motivation
Span events are now structured in core, and the
eventstag is only their v0.4/v0.5 encoding.Tests should assert span data, not a protocol detail.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
🤖 Generated with Claude Code