Repository navigation
Fix startup deadlock with virtual threads - #12786
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mcculls
left a comment
There was a problem hiding this comment.
LGTM, thanks for the regression test
There was a problem hiding this comment.
More details
VirtualThreadState is initialized before transformer installation, avoiding its first load during a virtual-thread mount transition. The fresh-process smoke test covers untraced virtual-thread startup with a bounded completion timeout.
🤖 Bits Code Review · Commit 6ca119b · @DataDog review to ask questions
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for d78cc03:
What to do next?
|
023d78a
into
master
What Does This Do
Tracer 1.67.0 can deadlock when the first untraced virtual thread loads VirtualThreadState inside mount(). The JVM’s instrumentation class-loading hook waits for mount transitions to finish, including the transition making that call.
Here we preload VirtualThreadState before installing the instrumentation. Add a fresh-process smoke test that starts a virtual thread without an active trace context.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]