Skip to content

🍒 12786 - Fix startup deadlock with virtual threads - #12788

Merged
amarziali merged 1 commit into
release/v1.67.xfrom
andrea.marziali/backport-pr-12786
Oct 8, 2026
Merged

amarziali merged 1 commit into
release/v1.67.xfrom
andrea.marziali/backport-pr-12786

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

Backport #12786 to release/v1.67.x

@amarziali
amarziali requested review from a team as code owners October 8, 2026 12:16
@amarziali
amarziali requested review from bric3 and removed request for a team October 8, 2026 12:16
@amarziali amarziali added type: bug fix Bug fix inst: java Core Java language instrumentation tag: concurrency Virtual Threads, Coroutines, Async, RX, Executors labels Oct 8, 2026
@amarziali
amarziali requested review from vandonr and removed request for a team October 8, 2026 12:16
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T12:19:09.090342Z da32c26 PR opened
🔒 Security Review ✅ Completed 2026-10-08T12:21:05.142509Z da32c26 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@amarziali
amarziali enabled auto-merge (squash) October 8, 2026 12:25

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Preloading VirtualThreadState before instrumentation installation addresses helper loading during virtual-thread mount transitions. The completed static review identified no actionable regressions; runtime behavior was not tested.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit da32c26 · @DataDog review to ask questions

@datadog-prod-us1-4

Copy link
Copy Markdown

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 68.82% (+9.50%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: da32c26 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.91 s [-0.1%; +1.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.98 s 13.02 s [-0.9%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.30 s 17.14 s [-0.2%; +2.0%] (no difference)
startup:petclinic:iast:Agent 17.08 s 17.06 s [-0.7%; +0.9%] (no difference)
startup:petclinic:profiling:Agent 16.57 s 16.88 s [-2.8%; -0.9%] (maybe better)
startup:petclinic:sca:Agent 17.15 s 16.97 s [+0.1%; +2.0%] (maybe worse)
startup:petclinic:tracing:Agent 16.21 s 16.29 s [-1.5%; +0.6%] (no difference)

Commit: da32c267 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali
amarziali merged commit 5941040 into release/v1.67.x Oct 8, 2026
609 of 615 checks passed
@amarziali
amarziali deleted the andrea.marziali/backport-pr-12786 branch October 8, 2026 13:10
@github-actions github-actions Bot added this to the 1.67.1 milestone Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: java Core Java language instrumentation tag: concurrency Virtual Threads, Coroutines, Async, RX, Executors type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants