Repository navigation
Support agentless log submission for Log4j 1 - #12728
daniel-mohedano wants to merge 4 commits into
Conversation
CI Visibility Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - heliboardJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - pass4sJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
CI Visibility Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
3d65fef to
0775202
Compare
CI Visibility Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - okhttpJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
0775202 to
0d1b1a6
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d1b1a6afc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
0d1b1a6 to
42e4378
Compare
There was a problem hiding this comment.
More details
The Log4j 1 submission path is covered by targeted instrumentation changes and preserves existing behavior, including MDC context and recursion avoidance. No introduced correctness issue was identified in the reviewed diff.
🤖 Bits Code Review · Commit 42e4378
There was a problem hiding this comment.
More details
The Log4j 1 agentless submission path follows the existing instrumentation pattern and the reviewed diff introduced no reportable correctness issue. Production telemetry was unavailable by workflow, and targeted Gradle execution was blocked by a sandbox certificate/network error.
🤖 Bits Code Review · Commit 42e4378
42e4378 to
ed01325
Compare
There was a problem hiding this comment.
The two most critical issues are: (1) LogsIntakeHelper reads the live thread MDC instead of the snapshot already captured on the LoggingEvent, causing agentless submissions to lose or overwrite the event's original MDC fields; and (2) the submission guard in CategoryInstrumentation is held for the entire callAppenders execution, meaning any re-entrant log event fired by a synchronous appender or layout is silently dropped regardless of its eligibility.
🤖 Bits Code Review · Commit ed01325
ed01325 to
2948c37
Compare
What Does This Do
Last PR of the agentless log submission stack. It adds Log4j 1.
Category.callAppenders(LoggingEvent)submits each event once.Stack:
Motivation
See the first PR of the stack. Log4j 1 already had correlation, but nothing submitted its events with agentless submission.
Additional Notes
log4j-over-slf4jreplacesCategory, so bridged applications are handled by the target backend. The smoke tests check that no events are duplicated.Testing:
:dd-smoke-tests:log-injection:testand Muzzle pass.Jira ticket: SDTEST-3805