Skip to content

Support agentless log submission for tinylog - #12727

Open
daniel-mohedano wants to merge 3 commits into
daniel.mohedano/agentless-logs-jboss-logmanagerfrom
daniel.mohedano/agentless-logs-tinylog
Open

daniel-mohedano wants to merge 3 commits into
daniel.mohedano/agentless-logs-jboss-logmanagerfrom
daniel.mohedano/agentless-logs-tinylog

Conversation

@daniel-mohedano

@daniel-mohedano daniel-mohedano commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Third PR of the agentless log submission stack. It adds tinylog 2.

  • When agentless log submission is enabled, a second advice on TinylogLoggingProvider.output submits each entry once.
    • It runs after the level check, on the producer thread, before the writing thread takes the entry.
  • tinylog only fills the entry values that its writers require, so the advice reads some values itself:
    • the thread name and the thread context, directly
    • the logger name: the class name when writers require it, otherwise the tag
  • The tinylog correlation modules are now context tracking modules, so context injection also works with CI Visibility when tracing is disabled.

Stack:

  1. Logback (Support agentless log submission for Logback #12725)
  2. Shared submission helper and JBoss LogManager (Support agentless log submission for JBoss LogManager #12726)
  3. tinylog 2 (this PR) (Support agentless log submission for tinylog #12727)
  4. Log4j 1 (Support agentless log submission for Log4j 1 #12728)

Motivation

See the first PR of the stack. tinylog already had correlation, but nothing submitted its entries with agentless submission.

Additional Notes

  • Entries without a required class name and without a tag are submitted without loggerName.
  • Nothing changes when agentless log submission is disabled, except the context injection fix above.
  • tinylog is not part of the log injection smoke tests.

Testing:

  • Forked JUnit 5 instrumentation tests on 2.0.0 and latest. They cover:
    • submission with levels, tags, formatted messages and exceptions
    • user context, child spans, no active span
    • two writers (sent once), the writing thread
    • injection disabled, CI Visibility with tracing disabled
  • Muzzle passes.

Jira ticket: SDTEST-3805

@daniel-mohedano daniel-mohedano added type: feature Enhancements and improvements comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM comp: logs Logs Product labels Oct 2, 2026
@daniel-mohedano
daniel-mohedano added this pull request to stack #12729 October 2, 2026 09:20
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 55.84 57.69 $\color{green}{\blacktriangledown}$ -1.85 56.55 $\color{green}{\blacktriangledown}$ -0.71 52/306
agentEvpProxy 56.46 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@datadog-official

datadog-official Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 59.70% (-3.62%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fddeb74 | Docs | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 36.96 37.15 $\color{green}{\blacktriangledown}$ -0.19 37.15 $\color{green}{\blacktriangledown}$ -0.19 28/168
agentless 37.23 37.15 $\color{red}{\blacktriangle}$ +0.08 36.42 $\color{red}{\blacktriangle}$ +0.81 28/141
agentlessCodeCoverage 45.55 45.38 $\color{red}{\blacktriangle}$ +0.17 45.38 $\color{red}{\blacktriangle}$ +0.17 27/139
agentlessLineCoverage 56.36 56.55 $\color{green}{\blacktriangledown}$ -0.19 56.55 $\color{green}{\blacktriangledown}$ -0.19 27/139

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 8.23 10.97 $\color{green}{\blacktriangledown}$ -2.74 10.13 $\color{green}{\blacktriangledown}$ -1.90 29/163
agentless 10.28 10.33 $\color{green}{\blacktriangledown}$ -0.05 9.73 $\color{red}{\blacktriangle}$ +0.55 27/132
agentlessCodeCoverage 10.74 18.45 $\color{green}{\blacktriangledown}$ -7.71 17.73 $\color{green}{\blacktriangledown}$ -6.99 23/121

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 90.45 91.39 $\color{green}{\blacktriangledown}$ -0.94 89.58 $\color{red}{\blacktriangle}$ +0.87 28/169
agentless 82.77 82.69 $\color{red}{\blacktriangle}$ +0.08 82.69 $\color{red}{\blacktriangle}$ +0.08 28/139
agentlessCodeCoverage 98.23 97.04 $\color{red}{\blacktriangle}$ +1.19 97.04 $\color{red}{\blacktriangle}$ +1.19 27/138
agentlessLineCoverage 113.99 113.88 $\color{red}{\blacktriangle}$ +0.11 113.88 $\color{red}{\blacktriangle}$ +0.11 26/138

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 10.10 9.92 $\color{red}{\blacktriangle}$ +0.18 9.92 $\color{red}{\blacktriangle}$ +0.18 26/136

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 22.68 22.54 $\color{red}{\blacktriangle}$ +0.14 22.09 $\color{red}{\blacktriangle}$ +0.59 30/169
agentless 19.01 19.59 $\color{green}{\blacktriangledown}$ -0.58 19.59 $\color{green}{\blacktriangledown}$ -0.58 28/135
agentlessCodeCoverage 19.96 19.99 $\color{green}{\blacktriangledown}$ -0.03 19.99 $\color{green}{\blacktriangledown}$ -0.03 28/135
agentlessLineCoverage 27.35 26.98 $\color{red}{\blacktriangle}$ +0.37 26.98 $\color{red}{\blacktriangle}$ +0.37 18/89

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from 3e2d8ea to 126265c Compare October 2, 2026 09:43
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 13.27 13.67 $\color{green}{\blacktriangledown}$ -0.40 13.40 $\color{green}{\blacktriangledown}$ -0.13 29/168
agentless 12.31 12.37 $\color{green}{\blacktriangledown}$ -0.06 12.12 $\color{red}{\blacktriangle}$ +0.19 29/138
agentlessCodeCoverage 15.75 15.72 $\color{red}{\blacktriangle}$ +0.03 15.41 $\color{red}{\blacktriangle}$ +0.34 28/137
agentlessLineCoverage 17.46 17.73 $\color{green}{\blacktriangledown}$ -0.27 17.38 $\color{red}{\blacktriangle}$ +0.08 27/136

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@dd-octo-sts

dd-octo-sts Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.90 s 13.91 s [-0.8%; +0.7%] (no difference)
startup:insecure-bank:tracing:Agent 12.89 s 12.95 s [-1.3%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.12 s 17.01 s [-0.1%; +1.4%] (no difference)
startup:petclinic:iast:Agent 17.03 s 17.07 s [-1.2%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.63 s 16.95 s [-3.2%; -0.6%] (maybe better)
startup:petclinic:sca:Agent 17.10 s 16.86 s [+0.4%; +2.4%] (maybe worse)
startup:petclinic:tracing:Agent 16.04 s 16.18 s [-2.1%; +0.4%] (no difference)

Commit: fddeb744 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 95.41 95.12 $\color{red}{\blacktriangle}$ +0.29 95.12 $\color{red}{\blacktriangle}$ +0.29 30/169
agentless 88.71 91.39 $\color{green}{\blacktriangledown}$ -2.68 89.58 $\color{green}{\blacktriangledown}$ -0.87 29/140
agentlessCodeCoverage 99.19 101.00 $\color{green}{\blacktriangledown}$ -1.81 99.00 $\color{red}{\blacktriangle}$ +0.19 29/141
agentlessLineCoverage 98.87 103.04 $\color{green}{\blacktriangledown}$ -4.17 101.00 $\color{green}{\blacktriangledown}$ -2.13 31/145

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 19.81 19.59 $\color{red}{\blacktriangle}$ +0.22 19.99 $\color{green}{\blacktriangledown}$ -0.18 29/169
agentless 19.45 18.82 $\color{red}{\blacktriangle}$ +0.63 19.59 $\color{green}{\blacktriangledown}$ -0.14 30/142
agentlessCodeCoverage 22.75 22.09 $\color{red}{\blacktriangle}$ +0.66 22.99 $\color{green}{\blacktriangledown}$ -0.24 31/145
agentlessLineCoverage 38.72 38.67 $\color{red}{\blacktriangle}$ +0.05 39.45 $\color{green}{\blacktriangledown}$ -0.73 27/138

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 16.58 16.36 $\color{red}{\blacktriangle}$ +0.22 16.36 $\color{red}{\blacktriangle}$ +0.22 29/165
agentless 10.77 9.92 $\color{red}{\blacktriangle}$ +0.85 9.92 $\color{red}{\blacktriangle}$ +0.85 29/137
agentlessCodeCoverage 14.11 13.67 $\color{red}{\blacktriangle}$ +0.44 13.67 $\color{red}{\blacktriangle}$ +0.44 29/139
agentlessLineCoverage 23.00 22.54 $\color{red}{\blacktriangle}$ +0.46 22.54 $\color{red}{\blacktriangle}$ +0.46 26/135

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 25.13 17.38 $\color{red}{\blacktriangle}$ +7.75 15.41 $\color{red}{\blacktriangle}$ +9.72 29/167
agentless 17.04 16.69 $\color{red}{\blacktriangle}$ +0.35 13.67 $\color{red}{\blacktriangle}$ +3.37 29/139
agentlessCodeCoverage 123.98 95.12 $\color{red}{\blacktriangle}$ +28.86 81.05 $\color{red}{\blacktriangle}$ +42.93 29/139
agentlessLineCoverage 152.21 123.36 $\color{red}{\blacktriangle}$ +28.85 123.36 $\color{red}{\blacktriangle}$ +28.85 28/141

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from 126265c to eb384d8 Compare October 2, 2026 10:48
@daniel-mohedano
daniel-mohedano marked this pull request as ready for review October 5, 2026 12:37
@daniel-mohedano
daniel-mohedano requested review from a team as code owners October 5, 2026 12:37
@daniel-mohedano
daniel-mohedano requested review from jordan-wong and removed request for a team October 5, 2026 12:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T12:47:48.620483Z eb384d8 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-05T13:02:34.388008Z eb384d8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The submission path preserves one-entry-per-call behavior before tinylog’s asynchronous writer handoff, while context injection remains available when tracing is disabled.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit eb384d8 · @DataDog review to ask questions

@daniel-mohedano
daniel-mohedano requested review from a team as code owners October 6, 2026 11:21
@daniel-mohedano
daniel-mohedano requested review from mcculls and removed request for a team October 6, 2026 11:21
@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from eb384d8 to ae60fcd Compare October 6, 2026 11:21
@daniel-mohedano daniel-mohedano removed the comp: logs Logs Product label Oct 6, 2026
@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from ae60fcd to dee1bdb Compare October 15, 2026 10:35
@daniel-mohedano
daniel-mohedano force-pushed the daniel.mohedano/agentless-logs-tinylog branch from dee1bdb to fddeb74 Compare October 15, 2026 12:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant