Skip to content

Add DD_PRIVATE_ACTION_RUNNER_SPLIT_ENABLED env var - #462

Merged
julesmcrt merged 1 commit into
mainfrom
jules.macret/par-split-enabled
Oct 2, 2026
Merged

julesmcrt merged 1 commit into
mainfrom
jules.macret/par-split-enabled

Conversation

@julesmcrt

Copy link
Copy Markdown
Contributor

Summary

  • Apply Gabriel Plassard’s change to support DD_PRIVATE_ACTION_RUNNER_SPLIT_ENABLED during initial Agent installation.
  • Write private_action_runner.split_enabled when explicitly provided (true or false); omit it otherwise to preserve the Agent’s platform default.
  • Add tests for enabled, disabled, and unspecified split mode. Existing configurations remain untouched.

Validation

  • All 64 shell unit tests passed in a Debian Docker container with the Agent installed.
  • ShellCheck passed over the CI script set (excluding the unit-test-generated extracted_functions.sh artifact).
  • make, Bash syntax checks, and git diff --check passed.

Co-authored with @gplassard.

Allow initial installations to explicitly configure PAR split mode while preserving the Agent default when the option is unset.

Co-authored-by: Gabriel Plassard <gabriel.plassard@datadoghq.com>
@julesmcrt
julesmcrt requested a review from a team as a code owner October 2, 2026 11:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T11:56:06.907585Z 92a65a5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 92a65a5 | Docs | View more details | Give us feedback!

@julesmcrt
julesmcrt merged commit 28a9ced into main Oct 2, 2026
355 checks passed
@julesmcrt
julesmcrt deleted the jules.macret/par-split-enabled branch October 2, 2026 15:01
@julesmcrt julesmcrt mentioned this pull request Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants