fix: native Windows Claude hooks — closes the last Windows finding (#259) — 8.7.2 - #263
Merged
Conversation
…259) Setup on Windows registered the POSIX .sh adapters unverified. Now: - The OMI-compliance guard (PreToolUse '*') and gate-reset (UserPromptSubmit) register direct omind invocations on Windows — `guard adapter --harness claude` / `guard preflight`, the pure-Python path the Codex harness already uses. Both platform forms are mutual strip-markers so a machine converges instead of accumulating entries. - The secret-output + fresh-base git guards (real bash logic) run through `sh "<script>"` when Git for Windows provides an sh, and are skipped with a clear warning when it doesn't; a new doctor `tool:sh` check surfaces the gap. fleet-sudo and the dead .sh copies are no longer written on Windows. - CLI output is forced to UTF-8 on Windows, fixing the doctor mojibake under PowerShell 5.1's default codepage. Also ticks #221/#222 in BACKLOG.md (issues closed-completed earlier but never checked — drift). Version 8.7.2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CryptoJones
added a commit
that referenced
this pull request
Aug 15, 2026
* test: pin the POSIX hook form in the seven platform-naive guard tests The #259 change made native Windows register direct omind hook commands, so the windows-latest CI runners started exercising the Windows path in tests that assert omi-guard.sh wiring — both Windows jobs failed on PR #263 and the merge went through anyway (my watch/merge chain was not gated; the release code itself is correct and guest-verified). A posix_form fixture pins _windows() False for those seven tests; the new Windows-path tests already pin True, so both forms stay covered on every runner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw * style: wrap the three signatures E501 flagged on the posix_form additions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259 — the last open item from the 2026-08-15 Windows fresh-install test, and the last actionable item on the backlog.
omind guard adapter --harness claude/omind guard preflighthook commands instead of unexecutable.shpaths (the same pure-Python path the Codex harness uses —guard selftestalready passes for all six harnesses on Windows). Cross-platform strip-markers make a provision converge when a machine switches forms.sh "<script>"when Git for Windows is present, otherwise setup skips them with a clear warning and doctor's newtool:shcheck flags the gap.fleet-sudoand dead.shcopies are no longer written on Windows.�mojibake under PowerShell 5.1.Tests: 6 new (Windows guard registration + convergence from the POSIX form, sh-missing skip, sh-present wrapping, doctor acceptance + sh probe, POSIX no-op). Full suite 982 passed, ruff clean, mypy clean, pip-audit clean. Version 8.7.2.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/