test: fix the seven POSIX-form guard tests on windows-latest - #264
Merged
Conversation
The #259 change made native Windows register direct omind hook commands, so the windows-latest CI runners started exercising the Windows path in tests that assert omi-guard.sh wiring — both Windows jobs failed on PR #263 and the merge went through anyway (my watch/merge chain was not gated; the release code itself is correct and guest-verified). A posix_form fixture pins _windows() False for those seven tests; the new Windows-path tests already pin True, so both forms stay covered on every runner. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs main's red Windows CI after #263: the native-Windows hook change means
windows-latestrunners genuinely take the Windows provisioning path, so the seven pre-existing tests assertingomi-guard.shwiring failed there. Aposix_formfixture pins_windows()to False for exactly those tests; the new Windows-path tests pin True, so both forms are covered on every OS. Tests only — no runtime change; the shipped 8.7.2 behavior is correct and was verified live in the win11 guest.Transparency note: PR #263 was merged while its Windows jobs were failing — my CI watch and merge were not properly chained. This PR turns main green again; the merge this time is gated on all checks.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QwU16vtyhZwcHf1BevWGSw
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/