Skip to content

Fix flaky CL tests #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettwrong merged 4 commits into from
Sep 29, 2026
Merged

Fix flaky CL tests #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52a7fab
Resolve test_oriented_source.py sporadic failures. Set Simulation see…
j-c-c Sep 28, 2026
dae1c7e
Resolve test_oriented_source.py sporadic failures. Set JSync epsilon …
j-c-c Sep 28, 2026
42dbbd7
Resolve another test_oriented_source failure. C3/C4 algorithms create…
j-c-c Sep 28, 2026
b3367bc
Resolve test_oriented_source.py save-roundtrip failure. Failure was d…
j-c-c Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/test_commonline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,11 @@ def test_J_sync(dtype):
Rijs_conjugated[ij] = Rij
ij += 1

# Initialize JSync instance with default params.
J_sync = JSync(n)
# Initialize JSync instance.
# For this small problem, set epsilon to 1e-3 (default is 1e-2)
# to prevent premature power method stoppage due to residual
# dipping below epsilon on a single early iteration.
J_sync = JSync(n, epsilon=1e-3)

# Perform power method and check that signs are correct up to
# multilication by -1. Also check dtype pass-through.
Expand Down
6 changes: 3 additions & 3 deletions tests/test_oriented_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def src_fixture_id(params):
@pytest.fixture(params=ESTIMATOR_SYMMETRY, ids=src_fixture_id)
def src_fixture(request):
estimator, symmetry = request.param
L = 8
L = 12 # Must be greater than 8 for Cn algos.
n = 10
vol = None

Expand All @@ -43,7 +43,7 @@ def src_fixture(request):
estimator_kwargs.update({"n_theta": 36, "symmetry": symmetry})

# Generate an origianl source and an oriented source.
og_src = Simulation(L=L, n=n, vols=vol, offsets=0)
og_src = Simulation(L=L, n=n, vols=vol, C=1, offsets=0, seed=0)
orient_est = estimator(og_src, max_shift=1 / L, mask=False, **estimator_kwargs)
oriented_src = OrientedSource(og_src, orient_est)

Expand Down Expand Up @@ -138,7 +138,7 @@ def test_save(src_fixture, save_mode):
Test save function and save_mode.
"""

src = src_fixture[1]
src = src_fixture[1].cache()

# Make a fresh tmp_dir
with tempfile.TemporaryDirectory() as tmp_dir:
Expand Down
Loading