Repository navigation
Fix flaky CL tests - #1413
Merged
Merged
Fix flaky CL tests#1413
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix_rng #1413 +/- ##
========================================
Coverage 90.07% 90.07%
========================================
Files 135 135
Lines 14997 14997
========================================
+ Hits 13508 13509 +1
+ Misses 1489 1488 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…d and use C=1 volumes.
…to 1e-3 for test.
… infeasible self-commonline search spaces for very low resolution (L=8). Setting L=12.
…ue to small batch size dependent errors originating in scipy fft. Caching the source avoided this.
j-c-c
force-pushed
the
flaky_cl_tests
branch
from
September 29, 2026 13:18
5e3e6f0 to
b3367bc
Compare
Collaborator
Author
|
Kicking off CI |
j-c-c
marked this pull request as ready for review
September 29, 2026 14:05
Collaborator
Author
|
@garrettwrong I think I resolved all the common-lines related failures. Hitting this one from test_noise.py: https://github.com/ComputationalCryoEM/ASPIRE-Python/actions/runs/36580044794/job/109446374767?pr=1413 |
Collaborator
|
Cool thanks, yeah I saw that one too. There will probably be a few more here/there. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving the remaining flaky CL tests.