Skip to content

CMP-4610: Fix scan name collision in TestTimeoutDisabledWithZeroValue - #1367

Merged
yuumasato merged 1 commit into
ComplianceAsCode:masterfrom
yuumasato:fix-timeout-test-scan-collision
Aug 21, 2026
Merged

CMP-4610: Fix scan name collision in TestTimeoutDisabledWithZeroValue#1367
yuumasato merged 1 commit into
ComplianceAsCode:masterfrom
yuumasato:fix-timeout-test-scan-collision

Conversation

@yuumasato

Copy link
Copy Markdown
Member

TestTimeoutDisabledWithZeroValue and TestScanSettingBindingUsesDefaultScanSetting both create ScanSettingBindings referencing the ocp4-cis Profile, causing the operator to create ComplianceScans with the same name in the same namespace. When running in parallel, the faster test's cleanup deletes the shared scan, causing the slower test to fail with "ocp4-cis not found".

Use ocp4-moderate instead since this test only validates timeout behavior and does not depend on any CIS-specific checks.

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

@guzalv: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TestTimeoutDisabledWithZeroValue and TestScanSettingBindingUsesDefaultScanSetting
both create ScanSettingBindings referencing the ocp4-cis Profile, causing the
operator to create ComplianceScans with the same name in the same namespace.
When running in parallel, the faster test's cleanup deletes the shared scan,
causing the slower test to fail with "ocp4-cis not found".

Use ocp4-moderate instead since this test only validates timeout behavior
and does not depend on any CIS-specific checks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@yuumasato
yuumasato force-pushed the fix-timeout-test-scan-collision branch from 3096f16 to 3b411cb Compare August 21, 2026 13:20
@github-actions

Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1367-3b411cbe0da2b6e87fb332a8b17b36fca0b8a304

@yuumasato yuumasato changed the title Fix scan name collision in TestTimeoutDisabledWithZeroValue CMP-4610: Fix scan name collision in TestTimeoutDisabledWithZeroValue Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Collaborator

@yuumasato: This pull request references CMP-4610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

TestTimeoutDisabledWithZeroValue and TestScanSettingBindingUsesDefaultScanSetting both create ScanSettingBindings referencing the ocp4-cis Profile, causing the operator to create ComplianceScans with the same name in the same namespace. When running in parallel, the faster test's cleanup deletes the shared scan, causing the slower test to fail with "ocp4-cis not found".

Use ocp4-moderate instead since this test only validates timeout behavior and does not depend on any CIS-specific checks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuumasato yuumasato added this to the 1.10.0 milestone Aug 21, 2026

@Vincent056 Vincent056 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guzalv, taimurhafeez, Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Vincent056,taimurhafeez,yuumasato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato
yuumasato merged commit be622ce into ComplianceAsCode:master Aug 21, 2026
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants