CMP-4571: Update coverage baseline after concurrent merges - #1365
Conversation
|
Hi @guzalv. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@guzalv: This pull request references CMP-4571 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
|
🤖 To deploy this PR, run the following command: |
|
@guzalv please set up commit signing: |
cmd/manager coverage improved from 24.1% to 24.4% after recent merges. Update the baseline so the coverage gate passes.
6300809 to
a6db1b6
Compare
|
/ok-to-test |
|
🤖 To deploy this PR, run the following command: |
|
The e2e-aws-parallel failure is unrelated to this PR.
This is a pre-existing flaky test bug, not a regression from the coverage baseline change. @guzalv Would you be okay addressing this issue in this PR as well? |
|
Or we could just retest and see if the race condition manifests again. |
Let’s see how the retest goes. In general I prefer to create separate PRs when an unrelated issue pops up. But merging with test failures is not nice and fixing that separately would mean an extra ci loop + wait time here. So if re-run fails I’ll make a fix right here! Thanks for the context |
|
I agree with separating as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guzalv, taimurhafeez, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Okay, I proposed the fix for the test in #1367 |
What
Update
coverage-baseline.txt:cmd/managercoverage improved from 24.1% to 24.4%.Why
The coverage gate (
make test-unit) is failing on master and all open PRs because recent merges improved coverage beyond the recorded baseline. The gate rejects the build when the baseline is stale.Changes
One-line change in
coverage-baseline.txt, generated bymake update-coverage-baseline.