Skip to content

London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KayanatSuleman wants to merge 9 commits into
base: main
Choose a base branch
from
+108 −100
Open

London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4ac3b87
Bug fix for loop
KayanatSuleman Apr 10, 2026
59f56c0
Bug fix incorrect variable fix
KayanatSuleman Apr 10, 2026
7e15f4a
Duplicate 'Title' value bug fix
KayanatSuleman Apr 10, 2026
9e99343
incorrect variable references and click spelling error
KayanatSuleman Apr 10, 2026
794d74c
incorrect boolean bug fix
KayanatSuleman Apr 10, 2026
710fda3
correcting the submit function bug
KayanatSuleman Apr 10, 2026
7514acb
Refactoring script.js
KayanatSuleman Apr 11, 2026
bd36b2a
correcting bug fix
KayanatSuleman Apr 11, 2026
18f3a98
refactoring code based on review comments
KayanatSuleman Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 26 additions & 25 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Library</title>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<link rel="stylesheet" href="style.css" />
</head>

<body>
Expand All @@ -23,46 +22,56 @@ <h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
<button
type="button"
data-toggle="collapse"
data-target="#demo"
class="btn btn-info"
>
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>

<label for="author">Author:</label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
required
/>

<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
/>
Read
</label>

<input
type="submit"
type="button"
value="Submit"
class="btn btn-primary"
onclick="submit();"
Expand All @@ -80,17 +89,9 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>

<script src="script.js"></script>
</body>
</html>
</html>
157 changes: 82 additions & 75 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,110 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true);

myLibrary.push(book1, book2);
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");
const displayTable = document.getElementById("display");
const tableBody = displayTable.querySelector("tbody");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
const titleValue = titleInput.value.trim();
const authorValue = authorInput.value.trim();
const pagesValue = Number(pagesInput.value);

if (titleValue === "" || authorValue === "" || !Number.isInteger(pagesValue) || pagesValue < 1) {
alert("Please fill all fields correctly.");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}

const book = new Book(titleValue, authorValue, pagesValue, readCheckbox.checked);
myLibrary.push(book);

titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readCheckbox.checked = false;

render();
return true;
}

function Book(title, author, pages, check) {
function Book(title, author, pages, isRead) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.isRead = isRead;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
tableBody.textContent = "";

for (const [index, book] of myLibrary.entries()) {
const row = document.createElement("tr");

const titleCell = document.createElement("td");
const authorCell = document.createElement("td");
const pagesCell = document.createElement("td");
const readCell = document.createElement("td");
const deleteCell = document.createElement("td");

titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

const toggleReadButton = document.createElement("button");
toggleReadButton.className = "btn btn-success";
toggleReadButton.textContent = book.isRead ? "Yes" : "No";
toggleReadButton.addEventListener("click", function () {
book.isRead = !book.isRead;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
const deleteButton = document.createElement("button");
deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";
deleteButton.addEventListener("click", function () {
myLibrary.splice(index, 1);
render();
showMessage(`You've deleted title: ${book.title}`);
});

readCell.appendChild(toggleReadButton);
deleteCell.appendChild(deleteButton);

row.appendChild(titleCell);
row.appendChild(authorCell);
row.appendChild(pagesCell);
row.appendChild(readCell);
row.appendChild(deleteCell);

tableBody.appendChild(row);
}
}

function showMessage(message) {
let messageBox = document.getElementById("message");

if (!messageBox) {
messageBox = document.createElement("div");
messageBox.id = "message";
messageBox.className = "alert alert-info mt-3";
displayTable.insertAdjacentElement("beforebegin", messageBox);
}

messageBox.textContent = message;
}
Comment on lines +99 to +110
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.

Currently, once the message is displayed, it does not go away when the user perform other tasks such as adding a new book.

As this is something extra, no change required.

Loading