London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library#420
Open
KayanatSuleman wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
London | JAN-ITP-26 | Kayanat Suleman | Sprint 2 | Book Library#420KayanatSuleman wants to merge 9 commits intoCodeYourFuture:mainfrom
KayanatSuleman wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
KayanatSuleman
added
Needs Review
cjyuan
reviewed
Apr 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
Author
|
@cjyuan Hi thank you for sharing - I have refactored the code now to based off the general review comments, Please see updated code base. Thank you. |
KayanatSuleman
added
Needs Review
cjyuan
reviewed
Apr 12, 2026
Comment on lines
+99
to
+110
| function showMessage(message) { | ||
| let messageBox = document.getElementById("message"); | ||
|
|
||
| if (!messageBox) { | ||
| messageBox = document.createElement("div"); | ||
| messageBox.id = "message"; | ||
| messageBox.className = "alert alert-info mt-3"; | ||
| displayTable.insertAdjacentElement("beforebegin", messageBox); | ||
| } | ||
|
|
||
| messageBox.textContent = message; | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Nice touch.
Currently, once the message is displayed, it does not go away when the user perform other tasks such as adding a new book.
As this is something extra, no change required.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist