Repository navigation
Manchester | 26-SDC-Jun | Fithi Teklom | Sprint 1 | Analyse And Refactor Functions - #259
Open
Fithi-Teklom wants to merge 1 commit into
Open
Fithi-Teklom wants to merge 1 commit into
Fithi-Teklom wants to merge 1 commit into
Conversation
Fithi-Teklom
added
the
Needs Review
cjyuan
reviewed
Oct 15, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Refactor code and complexity analyses look good. Well done.
Comment on lines
+13
to
+20
| const secondSet = new Set(secondArray); | ||
| const commonItems = new Set(); | ||
|
|
||
| for (const item of firstArray) { | ||
| if (secondSet.has(item)) { | ||
| commonItems.add(item); | ||
| } | ||
| } |
There was a problem hiding this comment.
Note:
Most Set implementations support the common set operations such as union, intersection, difference, subset, superset, equality, add, remove, contains, size, clear, and is empty.
You could consider taking advantage of them for optimal performance.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1173
Changelist
Refactored Sprint 1 exercises to improve efficiency by reducing time complexity where possible. All tests pass.