Repository navigation
chore(deps): update ESLint to v10 and its plugins to their new majors - #422
Merged
Merged
Conversation
ESLint 10 removed context.getSourceCode(), so the eslint-effect rules now read context.sourceCode, and its eslint peer range moves to >=8.40.0. eslint-plugin-functional 10 reports Record types as mutable, so those parameters are now Readonly. eslint-plugin-compat, eslint-plugin-package-json and eslint-plugin-expect-type are removed rather than upgraded, because no ESLint config loads them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Moves the repo to ESLint 10 with eslint-plugin-functional 10 and typescript-eslint 8.71. The rules enforced on the repo are unchanged.
knip.jsonignores everyeslint-plugin-*dependency. Say if you want any of them back.@codeforbreakfast/eslint-effectworks under ESLint 10 now. ESLint 10 removedcontext.getSourceCode(), which most of its rules called. Itseslintpeer range moves from>=8.0.0to>=8.40.0, the first release withcontext.sourceCode. One rule already needed 8.40.Record<…>parameters and return types as mutable. The fix wraps them inReadonly<…>, in the WebSocket server and inscripts/validate-changesets.ts.import/extensions, reports the same violation under ESLint 9 and 10.