scoreboards: require core 3.8.1; use its game-over check (sports family 5 adopt)

[ChuckBuilds]

Step 6 of family 5, the last one. Core v3.8.1 ships src.common.sports_game_over (LEDMatrix#770). The nine scoreboards now require 3.8.1, inherit SportsGameOverMixin and delete their identical _is_game_really_over copies, which #625 had reconciled. Nothing a user sees changes.

Changes

• Adoption: each SportsLive lists SportsGameOverMixin just before SportsLiveSharedMixin, the order core documents and tests. The import is plain, each plugin keeps its FINAL_PERIOD, and its copy is deleted. Baseball's BaseballLive not-played override stays, and its super() now reaches core's method.
• Minimum core 3.8.1, with minor bumps: afl 1.36.0, baseball 1.58.0, basketball 1.43.0, football 3.19.0, hockey 1.43.0, lacrosse 1.37.0, nrl 1.35.0, soccer 2.40.0, ufc 1.20.0. Each gets a versions[] entry, compatible_versions >=3.8.1, a CHANGELOG entry, and plugins.json.
• New guard, scripts/test_game_over_mixin_copies.py:
  • It fails if a copy returns. Only BaseballLive may define the method, and it must call super().
  • It also fails if the import is guarded or aliased, if the base is missing or in the wrong order, if a FINAL_PERIOD value drifts or appears elsewhere, or if core's mixin grows.
  • All 12 planted breakages were caught.
• Core-version table: v3.8.1 is tagged, so check_min_core_version.py dates the five modules it ships as 3.8.1: fetch_service, sports_game_over, display_arbiter, screen_runner and plugin_local_files. I checked each with git show v3.8.1:<path>. The tag test now tracks v3.8.1.
• Docs: doc 08 gets a "Converged at 3.8.1" note.

Verification

Compared against origin/main, both on the core v3.8.1 tag.

• Game-over answers: test_game_over_check.py passes all 3,115, unchanged, and its --print tables are byte-identical.
• Rendering: 192 harness PNGs across the nine plugins, 0 differ.
• Plugin tests: run_plugin_tests.py gives the same result per test (349 passed). The same 2 failures happen on main: test_football_plugin, which prompts for input, and test_baseball_activity.
• Repo scripts: all 49 scripts/test_*.py pass.
• Other checks: check_version_bump (naming all nine), update_registry --check, check_min_core_version, check_sports_drift and check_manifests_ascii all pass.
• MRO proof: all 18 league live managers resolve the method to core's mixin. The three baseball managers go through BaseballLive first.
• Core parity: core's test_sports_game_over_parity.py passes against this branch (118); deleted copies count as adopted.

Overlap: #620 conflicts in seven plugins' manifest and CHANGELOG and in plugins.json. Its sports.py changes merge cleanly. Whichever lands second re-bumps those seven.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8c994c72-6fa9-499b-8ebd-2cae990ccf70

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 107 complexity

Metric	Results
Complexity	107

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}