Repository navigation
chore(scripts): request_on_demand / end_on_demand ship in core 3.8.1 (core #768) - #633
Merged
Merged
Conversation
…core 3.8.1 (core #768) API_FIRST_VERSION gains the two on-demand methods core #768 added, first shipped in v3.8.1, and the table test's tracked tags run through 3.8.1 so the rows are verified against core's tags (3.8.0 lacks them, 3.8.1 has them). MODULE_FIRST_VERSION is already current: every 3.8.1 module is listed as "3.8.1" and src.malloc_tuning (core #774, after the tag) stays None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Core v3.8.1 is tagged (
a669d781). It contains core #768, which addedBasePlugin.request_on_demand()andend_on_demand(). This PR gives the core API guard rows for them.scripts/check_core_api_signatures.py:API_FIRST_VERSIONgainsrequest_on_demandandend_on_demand, both first shipped in3.8.1(core #768). The docstring no longer claims every row is from 3.4.0.scripts/test_check_core_api_signatures.py: the trackedTAGSlist now runs through 3.8.1, the same listtest_check_min_core_version.pyuses. Without this, a 3.8.1 row fails with "not a tracked tag".MODULE_FIRST_VERSIONneeds no change. scoreboards: require core 3.8.1; use its game-over check (sports family 5 adopt) #631 and chore(min-core): add src.malloc_tuning (core #774) as unreleased #632 already moved every 3.8.1 module to"3.8.1".src.malloc_tuning(core #774) merged after the tag, so it correctly staysNone.The four plugins that call these methods (birdnet-go, mqtt-notifications, on-air, pomodoro-timer) floor at 2.0.0. They still pass, because their calls are guarded, so no plugin needs a bump.
Test plan
Run with
LEDMATRIX_COREset to core main ate745ae80, with tags fetched through v3.8.1.test_check_core_api_signatures.py: all checks pass.3.8.0fails "not first shipped in 3.8.0".check_core_api_signatures.py: PASS. It sees 44 tracked calls (previously 38) and finds none that needs a newer core.test_check_min_core_version.py: all checks pass.scripts/test_*.py: exit 0.🤖 Generated with Claude Code