Skip to content

feat: attach structured context to desktop diagnostic uploads - #2252

Merged
richiemcilroy merged 4 commits into
mainfrom
codex/desktop-diagnostics-web-20260908
Sep 9, 2026
Merged

feat: attach structured context to desktop diagnostic uploads#2252
richiemcilroy merged 4 commits into
mainfrom
codex/desktop-diagnostics-web-20260908

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 8, 2026

Copy link
Copy Markdown
Member

Desktop support uploads now include a bounded JSON report alongside the log, with operation stages, return outcomes, and explicit coverage gaps. Existing diagnostic payloads remain accepted, Discord mentions are disabled, and webhook delivery requests confirmation.

Validation: all 12 desktop-log-upload tests, scoped Biome, and git diff --check pass. Actual webhook delivery was not exercised. The structured operation producer will be delivered with the desktop release PR #2219; existing clients remain compatible.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge with no outstanding findings.

Summary

  • Uploads the original log alongside a bounded JSON diagnostic attachment.
  • Reconstructs operation stages and outcomes from snapshots and retained log records.
  • Reports invalid, unsupported, omitted, and incomplete diagnostic coverage.
  • Disables Discord mentions and requests synchronous webhook confirmation.
  • Adds unit coverage for legacy payloads, size limits, duplicate stages, rotated logs, and operation limits.

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread apps/web/lib/desktop-diagnostic-analysis.ts Outdated
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy marked this pull request as ready for review September 8, 2026 22:41
@richiemcilroy
richiemcilroy merged commit 1d544e4 into main Sep 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant