Skip to content

feat: prepare desktop editors, recording reliability and diagnostics - #2219

Merged
richiemcilroy merged 21 commits into
mainfrom
codex/desktop-release-readiness
Sep 9, 2026
Merged

feat: prepare desktop editors, recording reliability and diagnostics#2219
richiemcilroy merged 21 commits into
mainfrom
codex/desktop-release-readiness

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 4, 2026

Copy link
Copy Markdown
Member

Both desktop editors now support timed style and image tracks, saved ordering across text/image/mask layers, 3D scene controls, and consistent caption and keyboard timing through cuts. Preview and export use the saved project configuration, and late GPUI export previews cannot replace a newer request or a reopened window.

The release also includes recording quality controls, browser-based pricing, safer device and permission lifecycles, bounded recording shutdown and recovery, structured operation diagnostics, and safer native save/export behavior. Linux camera, Wayland capture/Stop handling and installed ONNX Runtime lookup are included, along with macOS 12.3 packaging and the camera enumeration fixes from #2248. The structured diagnostic upload endpoint is in #2252. Desktop release notes are included.

Validation: 351 desktop frontend tests, 922 GPUI tests and 859 tests across Tauri, project configuration, rendering, camera effects and utilities pass. Seven shared-crate tests and one GPUI test remain intentionally ignored by their existing suites. Forty-seven packaging tests, desktop TypeScript, scoped Biome, root/GPUI formatting and desktop frontend production build pass. Both native applications compile with all test targets. CI-equivalent workspace Clippy with all features and warnings denied passes on macOS. Tauri bindings were regenerated with typescript_bindings_tests::export_typescript_bindings, and the frontend build regenerated the icon declarations. One existing upload scheduling test needed lower test concurrency to meet its timing threshold.

The final snapshot comparison preserved the original editor control bindings and overlay rows. Stop requests now release their pending state on completion and retain errors, with regressions for retry and stale completion. Forty-two GPUI timeline tests and the frontend production build pass after those corrections.

Build metadata probes use explicit system Git paths. Custom installations can set CAP_BUILD_GIT to an absolute executable path. An executable shadowing Git on PATH and a relative override are both rejected; native checks and Clippy pass.

Greptile reached a fresh 5/5 on this revision with no unresolved review threads. All current CI checks pass, including macOS, Windows and Linux desktop builds, platform Clippy, synchronization tests, typechecking and security scans. Packaged native UI, low-storage Stop/recovery/Quit, signed packages/updater behavior and A/V performance remain release validation gates; local compilation and unit tests do not establish those results.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge based on the reviewed changes, with no outstanding blocking findings.

Summary

  • Adds timed style and image tracks, persistent layer ordering, 3D scene controls, and cut-aware caption and keyboard timing.
  • Improves recording shutdown, recovery, permissions, native save/export behavior, and operation diagnostics.
  • Adds Linux camera and Wayland support, installed ONNX Runtime discovery, macOS 12.3 packaging, and broader release validation.
  • The latest revision hardens build metadata collection by using explicit Git executable paths and an absolute CAP_BUILD_GIT override.

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread apps/desktop/src/routes/editor/context.ts Outdated
Comment thread apps/desktop-gpui/src/editor_export.rs
Comment thread apps/desktop/src/utils/tauri.ts
Comment thread apps/desktop/src/routes/editor/image-overlay.tsx
@richiemcilroy
richiemcilroy marked this pull request as ready for review September 4, 2026 14:54
@richiemcilroy richiemcilroy changed the title feat: prepare desktop release with style tracks and recording reliability feat: prepare desktop editors, recording reliability and diagnostics Sep 8, 2026
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@superagent-security superagent-security Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

Comment thread scripts/diagnostic-build.rs
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit d611eb6 into main Sep 9, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant