feat: prepare desktop editors, recording reliability and diagnostics - #2219
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
richiemcilroy
marked this pull request as ready for review
September 4, 2026 14:54
…ources fix: stop repeated Windows camera resource allocation
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both desktop editors now support timed style and image tracks, saved ordering across text/image/mask layers, 3D scene controls, and consistent caption and keyboard timing through cuts. Preview and export use the saved project configuration, and late GPUI export previews cannot replace a newer request or a reopened window.
The release also includes recording quality controls, browser-based pricing, safer device and permission lifecycles, bounded recording shutdown and recovery, structured operation diagnostics, and safer native save/export behavior. Linux camera, Wayland capture/Stop handling and installed ONNX Runtime lookup are included, along with macOS 12.3 packaging and the camera enumeration fixes from #2248. The structured diagnostic upload endpoint is in #2252. Desktop release notes are included.
Validation: 351 desktop frontend tests, 922 GPUI tests and 859 tests across Tauri, project configuration, rendering, camera effects and utilities pass. Seven shared-crate tests and one GPUI test remain intentionally ignored by their existing suites. Forty-seven packaging tests, desktop TypeScript, scoped Biome, root/GPUI formatting and desktop frontend production build pass. Both native applications compile with all test targets. CI-equivalent workspace Clippy with all features and warnings denied passes on macOS. Tauri bindings were regenerated with typescript_bindings_tests::export_typescript_bindings, and the frontend build regenerated the icon declarations. One existing upload scheduling test needed lower test concurrency to meet its timing threshold.
The final snapshot comparison preserved the original editor control bindings and overlay rows. Stop requests now release their pending state on completion and retain errors, with regressions for retry and stale completion. Forty-two GPUI timeline tests and the frontend production build pass after those corrections.
Build metadata probes use explicit system Git paths. Custom installations can set CAP_BUILD_GIT to an absolute executable path. An executable shadowing Git on PATH and a relative override are both rejected; native checks and Clippy pass.
Greptile reached a fresh 5/5 on this revision with no unresolved review threads. All current CI checks pass, including macOS, Windows and Linux desktop builds, platform Clippy, synchronization tests, typechecking and security scans. Packaged native UI, low-storage Stop/recovery/Quit, signed packages/updater behavior and A/V performance remain release validation gates; local compilation and unit tests do not establish those results.
The PR appears safe to merge based on the reviewed changes, with no outstanding blocking findings.
Summary
CAP_BUILD_GIToverride.