Repository navigation
Tidy comments in BoxProvisioning.Sqlite - #4591
Merged
Merged
Conversation
Delete comments that narrate code or repeat rationale already in ADR 0057, strip spec, issue and PR references, trim XML remarks that duplicated the runner's or pointed at other files' line numbers, move the busy-timeout note above ToDriverBusyTimeoutSeconds, and turn the LockResourceFor comment into XML remarks on the protected override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7
Replace the explanatory comment in SqliteBoxMigrationRunner.ApplyOrSkipAsync by decomposing its conditional into a private IsAlreadyAppliedAsync, keeping one line above the signature for the history-row trap the name cannot carry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
October 12, 2026 06:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 2 of the comment tidy over PR #4039's merge (
83e0e5e47), bringingsrc/Paramore.Brighter.BoxProvisioning.Sqliteinto line with Comments in Code. Slice 1 was #4590.Structural only. There are no behaviour changes and no public or protected signature changes.
refactor: tidy comments— deletes comments that narrate code or repeat rationale already in ADR 0057 (history-table race, fresh-install fast path), strips spec, issue and PR references, and trims XML remarks that duplicated the runner's or cited other files' line numbers. The busy-timeout note moves aboveToDriverBusyTimeoutSeconds, and theLockResourceForcomment becomes XML remarks on the protected override.refactor: extract methods to express intent— decomposes the conditional inSqliteBoxMigrationRunner.ApplyOrSkipAsyncinto a privateIsAlreadyAppliedAsync.No ADR change was needed: everything removed was already in ADR 0057/0058, or stays in the public XML remarks.
Verification
dotnet build src/Paramore.Brighter.BoxProvisioning.Sqlite— no warningstests/Paramore.Brighter.BoxProvisioning.Tests— 111/111 passtests/Paramore.Brighter.Sqlite.Tests --filter BoxProvisioning— 66/66 pass, unedited🤖 Generated with Claude Code
https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7