Repository navigation
Tidy comments in BoxProvisioning.PostgreSql (slice 3) - #4592
Merged
Merged
Conversation
… rationale in ADRs 0057 and 0060 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7
…eSql Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
October 12, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 3 of the comment tidy over PR #4039's merge (
/refactor:tidy-comments 83e0e5e47^1..83e0e5e47 src/Paramore.Brighter.BoxProvisioning.PostgreSql), applying the decisions from slices 1 and 2 (#4590, #4591). Structural only — no behaviour or public/protected signature changes.Commits
CREATEruns inside a savepoint, because Postgres aborts the transaction on the duplicate error even when it is caught (25P02).PerSchemaprovision (the table-level gate made the second box type to flip skip its seed), and a legacy-history read failure throwsConfigurationException, filtered to permission-denied codes only. Applies to MSSQL and PostgreSQL.///on private members to//;LockResourceForgets<inheritdoc/>+<remarks>; fixes<param>docs that cited a non-existent "ADR 0057 §A.1".HistoryTableExistsAsync(detection helper);ValidatedHistorySchema(removes a duplicated resolve-and-validate) andCreateHistoryTableAsync(runner);ReleaseLockAfterFailedBeginAsyncandLogLockNotHeld(unit of work, removes a duplicated warning); the"42501"literal becomesPostgresErrorCodes.InsufficientPrivilege.Verification
dotnet buildof the project: 0 warnings, 0 errors.Paramore.Brighter.BoxProvisioning.Tests: 111/111 passed (unedited).Paramore.Brighter.PostgresSQL.Tests --filter FullyQualifiedName~BoxProvisioningagainst a Postgres container: 88/88 passed (unedited).🤖 Generated with Claude Code
https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7