Repository navigation
Preserve review evidence and required test artifacts - #3635
Conversation
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 1 minute. View limit details
Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoPreserve test artifacts and add portable Codex hook guidance
AI Description
Diagram
High-Level Assessment
Files changed (23)
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbb9370a53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
- Exclude hyphenated report merges from reuse - Allow memoisation for focused related runs
- Pin the hook adapter to the trusted project - Dispatch protected-file edit warnings - Add Windows Node and Bash fallbacks
push-format-guard.sh and the Codex dispatcher's GIT_PUSH missed `git -C '/tmp/My Repo' push` (no single-quoted alternative in the guard) and `git -C/tmp/repo push` (whitespace after -C was required), so the format check could be skipped. Both matchers now accept a single-quoted, double-quoted or attached -C value. Regression tests cover both forms, including in the guard's unwired pre-push case.
|
Code review by qodo was updated up to the latest commit b9c7b1c |
…al vitest memoisation rule - verify:cheap:internal ran test:codex-hooks before check:installed-lock-parity, and the parity contract treats "npm run test:codex-hooks" as the first test interpretation. Run the stale-install check first, as the contract requires. - gate-receipts coverage-form tests scraped a one-line regex out of scripts/run-vitest.mjs, which stopped matching once the constant was reformatted across two lines. Call the exported vitestRunIsMemoisable instead so the assertions exercise the real decision. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V2VWJXoHMnr3XnAhrREN8V
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V2VWJXoHMnr3XnAhrREN8V
|
Code review by qodo was updated up to the latest commit fd4831e |
|
Grok Bot sweep coordination: I took the three |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Code review by qodo was updated up to the latest commit fd4831e |
Qodo FixerFound 12 findings, but none include a fix that can be applied automatically. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd4831e44b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The Codex adapter and the shared handoff hook only matched an adjacent 'gh pr create', so 'gh --repo X pr create' or 'gh pr -R X create' never wrote the PR handoff marker. Accept gh's inherited -R/--repo flag between the words in both places, with tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V2VWJXoHMnr3XnAhrREN8V
My earlier left anchor required whitespace or a separator before gh, so $(gh pr create), quoted shell strings and /usr/bin/gh no longer reached the handoff hook. Use a word-boundary lookbehind instead, and add those forms to the adapter tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V2VWJXoHMnr3XnAhrREN8V
Code Review ✅ Approved 4 closed / 4 findings🔴 High risk · Automatically authorizing scoped Supermemory writes for nonclinical project decisions could persist content in an unintended namespace if agents misread scope. Restricts Vitest result receipt reuse to eligible console runs, makes the push guard refuse when Node is missing, and adds a portable Codex hook adapter that routes supported events to existing hooks. Resolved this session: kebab-case ✅ 4 closed✅ Edge Case: Kebab-case --merge-reports still allows receipt reuse
✅ Bug: Windows bash lookup can pick the WSL launcher instead of Git Bash
✅ Bug: Push guard regex skips single-quoted -C paths that the adapter routes
✅ Bug: GH_PR_CREATE left anchor drops
|
| Auto-apply | Compact |
|
|
Important
Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
|
Code review by qodo was updated up to the latest commit e30a90e |
User description
Summary
Result receipts could be reused for commands requiring report artifacts or interactive execution, and a missing Node runtime allowed the required push guard to be skipped. Restrict receipt reuse to eligible console runs, clarify the limits of committed review evidence, and refuse a push when the guard cannot run. Add the portable advisory Codex hook adapter and its synthetic checks, correct Windows Cloud fixtures and a lazy-render assertion, and align the shared operating guidance while retaining PsychSift's product-specific controls.
Areas touched: Knowledge and records, Delivery and assurance, Personal practice
Verification
Local evidence is composite: the earlier full
verify:pr-localinvocation failed in three test files (28 failed tests; 31,880 passed). After correcting those files, the later selected run passed 160 tests with eight existing platform skips and zero failures, with a real JSON report. The normal pre-push guard then found a TypeScript inference error in the two synthetic Cloud fixture helpers. After the two-line type correction, their fresh two-file run passed 158 tests with zero failures/eight skips and a real JSON report; normal source typecheck and scoped formatting also passed. The three previously unreached RAG/medication selectors passed separately. Fourteen synthetic adapter checks, documentation/organisation and rule-consistency checks passed. This is not a passing full-wrapper invocation on final HEAD.The reviewed delivery adds the two-line fixture type correction on top of
9a0c6a518188c73304d54728ea762d09c95d1168, retaining the same 18 changed paths. Exact-main comparison against62558e5c7cb6fa2cbc12944093d0d053240cb351found no superseded repair or textual merge conflict. The pre-publication main snapshot advanced tob12f3d4b3f5deda6eaff00e460550f2ec1bdaf26in one commit changing only five disjoint Supabase/SQL paths; the inspected workflow chain and 18 delivery paths did not change. Main's independent AGENTS and organisation-map entries must be preserved. Main has newer dependencies, so local branch evidence does not certify the eventual merge tree.Risk and rollout
This is a draft for review. Its hosted static checks remain pending until executed. Draft coverage/safety and automatic Claude review are deliberately deferred; native hook dispatch, clinical sign-off, merge and deployment are not certified by this change.
Summary by cubic
Vitest result receipts now reuse only for eligible console runs, and the pre-push guard blocks pushes when Node is missing. A portable Codex adapter adds advisory repository safeguards by routing supported events to the existing Claude hooks without running tool commands.
apply_patch, warns about protected-file edits, detectsgh pr createeven with an inherited-R/--repoflag, command substitution, quoting, or a path prefix, and keeps push detection intact when git global options — including single-quoted, double-quoted, and attached-Cvalues — precedepush; its tests run inverify:cheap:internalafter the stale-install parity check.Written for commit e30a90e. Summary will update on new commits.
CodeAnt-AI Description
Make test-result reuse safe, enforce push checks, and add Codex hooks
What Changed
Impact
✅ Fresh reports from artifact-producing test runs✅ No push-guard bypass when Node is missing✅ Codex users receive project-specific safety guidance💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.