Repository navigation
Fix Windows hook bootstrap and bound complete container evidence - #3655
Conversation
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 45 minutes. View limit details
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
Auto-fix isn't included in your plan ↗ |
# Conflicts: # docs/scripts-index.md
…fixture cleanup retries
Code Review ✅ Approved🟡 Medium risk · Requiring a complete bounded Buildx evidence archive could fail container CI and withhold artifacts when export or size checks fail. Fixes the Windows Codex hook bootstrap to accept equivalent casing of the same checkout directory while rejecting foreign checkouts, and bundles container SBOMs and Docker build history into one bounded VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Summary
Complete the remaining agent-policy repairs after #3635 merged. Windows hook bootstrap now accepts equivalent casing of the same directory while rejecting a foreign checkout; its test imports the maintained adapter through a file URL. Shared memory guidance matches the canonical managed source while retaining all PsychSift-specific instructions.
Container validation retains complete available SBOMs and mandatory finalized build history in one raw
sbomsarchive capped at64MiB/seven days. Export errors cannot suppress image/runtime/vulnerability checks; invalid or oversized evidence prevents upload. The archive helper's own changes now select container validation. Download the artifact and runtar -xf sbomsto read the manifest, SBOMs and complete Docker build record.Areas touched: Knowledge and records, Delivery and assurance
Verification
Repair source commit:94b9b8ed9e38230f55c9b6d6b250a44b03c20fb1. Prepared tip with the immutable review receipt:d8e7fd938ffca247a400e08a3552bf785339bb3d. Current publication tip after a normal merge of current main:2fb89dee206c6a501b3c6bffba6bc7c7c824b9a3. Current base:1837b0b4197c5efb8de80636fa9b23bc17425fb2. Exact-range ledger write discipline and diff-integrity checks passed (two changed test files,15to23test cases).
Fresh after integration with current main:30/30 focused container-contract and bot-author policy tests passed, zero skips/failures; documentation checks passed. Current-main snapshot union and source checks retain all reviewed repair blobs, plus all newer base policy/container changes. Main already includes the AGENTS memory correction, so the net follow-up has17changed paths. Earlier checks above retain their stated input/scope.
Risk and rollout
Notes
Hosted acceptance for this follow-up is pending. Local synthetic checks and source review do not prove native lifecycle loading, POSIX dispatch, actual Ubuntu Docker history export/upload, a passing full application suite or all-client activation. A prior mixed Windows Node/Git Bash tar replay failed; separate native archive and mocked shell controls passed. The selected draft Cloud source check is static; the separate native Windows bootstrap workflow is outside this follow-up's path selection.
Summary by cubic
Fixes Windows Codex hook checkout matching and replaces separate SBOM uploads with one complete, bounded container-evidence archive.
Windows hook bootstrap
Container evidence
sbomstar capped at 64 MiB with seven-day retention.tar -xf sboms; the artifact tests are included in the CI workflow suite.Written for commit e5851ba. Summary will update on new commits.