Skip to content

Fix Windows hook bootstrap and bound complete container evidence - #3655

Merged
gitar-bot[bot] merged 5 commits into
mainfrom
codex/agent-policy-final-followup-20261018
Oct 18, 2026
Merged

gitar-bot[bot] merged 5 commits into
mainfrom
codex/agent-policy-final-followup-20261018

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Complete the remaining agent-policy repairs after #3635 merged. Windows hook bootstrap now accepts equivalent casing of the same directory while rejecting a foreign checkout; its test imports the maintained adapter through a file URL. Shared memory guidance matches the canonical managed source while retaining all PsychSift-specific instructions.

Container validation retains complete available SBOMs and mandatory finalized build history in one raw sboms archive capped at64MiB/seven days. Export errors cannot suppress image/runtime/vulnerability checks; invalid or oversized evidence prevents upload. The archive helper's own changes now select container validation. Download the artifact and run tar -xf sboms to read the manifest, SBOMs and complete Docker build record.

Areas touched: Knowledge and records, Delivery and assurance

Verification

  • Independent bounded integration review: main's newer migration-policy decision, guards and documentation preserved; external gh-command matching preserved; retained repair hashes matched. Generated snapshot union preserves all existing main entries.
  • Fresh focused Windows Node attempt:15 passed, one five-second fixture timeout. The exact timed-out test then passed in isolation with unchanged assertions and timeout. This is composite evidence, not a wholly passing full invocation.
  • Fresh six-file Vitest selection:92 passed, one thirty-second receipt-test timeout,31 existing Windows platform skips. The exact timed-out receipt case passed separately with unchanged assertions and timeout. Actual JSON reports retained locally. No claim that skipped POSIX cases ran.
  • Source typecheck, scoped lint, formatting, documentation maintenance and required inner checks, normal commit hooks and diff checks passed. Earlier independent artifact/identity controls and focused47/47 container/CI-scope and46/46 verifier/receipt results retain their original source identity and scope.

Repair source commit:94b9b8ed9e38230f55c9b6d6b250a44b03c20fb1. Prepared tip with the immutable review receipt:d8e7fd938ffca247a400e08a3552bf785339bb3d. Current publication tip after a normal merge of current main:2fb89dee206c6a501b3c6bffba6bc7c7c824b9a3. Current base:1837b0b4197c5efb8de80636fa9b23bc17425fb2. Exact-range ledger write discipline and diff-integrity checks passed (two changed test files,15to23test cases).

Fresh after integration with current main:30/30 focused container-contract and bot-author policy tests passed, zero skips/failures; documentation checks passed. Current-main snapshot union and source checks retain all reviewed repair blobs, plus all newer base policy/container changes. Main already includes the AGENTS memory correction, so the net follow-up has17changed paths. Earlier checks above retain their stated input/scope.

Risk and rollout

  • Risk: agent tooling and container evidence packaging. No migration, clinical, authentication, application dependency or ranking changes. Retain complete evidence or fail visibly; no truncation or partial upload.
  • Rollback: reviewed additive revert of affected repairs; preserve guards and evidence requirements.
  • Provider effects: the proposed authority covers one draft publication/standard public Actions wave only, estimated US$0–0.005, hard US$0.01, single64MiB raw artifact/seven days, no reruns or model API calls. No ready-for-review, auto-merge, merge or deployment.

Notes

Hosted acceptance for this follow-up is pending. Local synthetic checks and source review do not prove native lifecycle loading, POSIX dispatch, actual Ubuntu Docker history export/upload, a passing full application suite or all-client activation. A prior mixed Windows Node/Git Bash tar replay failed; separate native archive and mocked shell controls passed. The selected draft Cloud source check is static; the separate native Windows bootstrap workflow is outside this follow-up's path selection.


Summary by cubic

Fixes Windows Codex hook checkout matching and replaces separate SBOM uploads with one complete, bounded container-evidence archive.

Windows hook bootstrap

  • Accepts case variants of the same checkout by filesystem identity and rejects foreign checkouts before importing their adapter.
  • Adds Windows path coverage using file URLs.

Container evidence

  • Bundles finalized Buildx history, available SBOMs, and a manifest into a raw sboms tar capped at 64 MiB with seven-day retention.
  • Missing SBOMs are recorded; failed exports or invalid, missing, or oversized evidence block upload without suppressing image, runtime, or vulnerability checks.
  • Extract the artifact with tar -xf sboms; the artifact tests are included in the CI workflow suite.

Written for commit e5851ba. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 126 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: BigSimmo/PsychSift/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: f4025b66-132d-472a-b340-b2b68ee3d0db
📥 Commits

Reviewing files that changed from the base of the PR and between b907b5c and e5851ba.

📒 Files selected for processing: 18
  • .codex/hooks.json
  • .codex/hooks/dispatch.mjs
  • .codex/hooks/dispatch.test.mjs
  • .github/workflows/docker-image.yml
  • data/repo-awareness-snapshot.json
  • docs/agents/shared-context-and-memory.md
  • docs/branch-review-index.md
  • docs/branch-review-records/2fe7bb2f3b87b710b26cd25245660dea4b6dc4d7e6d2fcb8cd228e41aef2b09f.record.md
  • docs/branch-review-records/319e0e7f3ddc83fabb3b5b0b766336fe2bafb04bebe5e2fcce4d65d7f643ed20.record.md
  • docs/branch-review-records/479f91d15b90c2a4011b808f31960d356d8602298dd84b059c6004a4516f0336.record.md
  • docs/branch-review-records/611d5dd408f6ba42ed7c869a095389b8ef918a511c6cb3020774e633bbdecd5f.record.md
  • docs/ci-operations.md
  • docs/organisation/systems/delivery.json
  • docs/scripts-index.md
  • package.json
  • scripts/ci-change-scope.mjs
  • scripts/ci/archive-container-evidence.mjs
  • tests/container-evidence-artifacts.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Oct 18, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

gitar-bot[bot]
gitar-bot Bot previously approved these changes Oct 18, 2026

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@BigSimmo
BigSimmo marked this pull request as ready for review October 18, 2026 12:51

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T12:54:09.148636Z 2fb89de Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Auto-fix isn't included in your plan ↗

Upgrade to Team

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR (configure)

@gitar-bot

gitar-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor
Code Review ✅ Approved

🟡 Medium risk · Requiring a complete bounded Buildx evidence archive could fail container CI and withhold artifacts when export or size checks fail.

Fixes the Windows Codex hook bootstrap to accept equivalent casing of the same checkout directory while rejecting foreign checkouts, and bundles container SBOMs and Docker build history into one bounded sboms archive. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Approved

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot
gitar-bot Bot merged commit a300f70 into main Oct 18, 2026
38 checks passed
@gitar-bot
gitar-bot Bot deleted the codex/agent-policy-final-followup-20261018 branch October 18, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant