Repository navigation
Reconcile Cloud setup ownership and coding-agent rules - #3597
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 29 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 13.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 60 functions across 28 files. (3 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly summarizes the main changes to Cloud setup ownership and coding-agent rules. Description check The description includes the required Summary, Verification, Risk and rollout, and Notes sections. It provides affected areas, test evidence, risks, rollback, provider impact, and rollout context.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 13.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 60 functions across 28 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
codeant-ai
Bot
added
the
size:XXL
PR Summary by QodoReconcile Cloud setup ownership and agent verification rules
AI Description
Diagram
High-Level Assessment
Files changed (58)
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 926d5f5da4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Review by Qodo
No findings for this group No findings for this group 1. Setup checks the same destinations twice
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
- Ignore warning-level scan diagnostics - Validate SARIF run structures
Qodo Fixer✅ Committed (7) · ☑ Fixed (7) Commits pushed directly to this PR — no separate fix PR opened. Process — 7 fixed
|
CodeAnt Nitpicks4 code suggestions1. This template omits
|
Capture unexpected locator.evaluate failures inside expectHydrated's poll, end the poll, and re-throw afterwards so they never depend on expect.poll retrying or propagating callback errors. Add tests that swap in a retrying expect.poll to prove the failure surfaces after exactly one evaluation.
# Conflicts: # tests/ui-tools.spec.ts
|
Code review by qodo was updated up to the latest commit af8d885 |
|
Auto-fix isn't included in your plan ↗ |
…n probe Conflicts with #3604 (cloud setup lifecycle hardening) resolved keeping both sides: - shims: PR's resolved-target pinning, managed-destination checks, per-checkout wrappers and mv -fT, plus main's bounded (timeout) npm/npx version probes, now applied to bundled npm/npx too - setup: PR's early validation and checkout-bound profile, plus main's strict CODEX_HOME validation, setup-target checks, npx repair, and writing the runtime profile only after config admission (both moved with mv -fT) - tests: both sides' new tests kept; main's fixtures use managed/checkout-bound profiles and an npx stub as the PR's stricter rules require; error messages carry both sides' wording; checker requires main's stricter CODEX_HOME form Production UI (3): expectHydrated matched the navigation context-loss message only with a trailing period; Playwright's context-destroyed path omits it, so the services redirect failed fast. Match the stable stem and cover both forms.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Auto-approval revoked — new findings require attention.
|
Code review by qodo was updated up to the latest commit aae39fd |
The installer now writes exec '<path>' "$@" via codex_cloud_shell_quote, but generated_shim_targets_present only parsed the double-quoted form, so every maintenance run fell back to full setup. Parse both forms and undo the quote helper's '\'' escapes; regression test covers a quoted path with an apostrophe.
|
Code review by qodo was updated up to the latest commit 6ecf660 |
Legacy double-quoted shims carry their target verbatim, so a literal '\'' in such a path must not be rewritten. Parse the single-quoted form first and undo codex_cloud_shell_quote escapes only there; regression test for the legacy form.
Code Review ✅ Approved 3 closed / 3 findings🔴 High risk · Claude/Codex setup reconciles persistent host configs and startup files; ownership or checkout mistakes could remove managed user configuration or disrupt agent startup. Reconciles Cloud setup ownership and coding-agent rules, including Semgrep scan-status validation, bootstrap errexit handling, and maintenance shim-target parsing. No open issues remain; the scan-status batch failure, the bootstrap ✅ 3 closed✅ Bug: scan-status fails any batch with non-fatal Semgrep JSON errors
✅ Bug:
|
| Auto-apply | Compact |
|
|
Important
Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
|
Code review by qodo was updated up to the latest commit 677ee34 |
User description
Summary
Fixes Cloud bootstrap and installed-guidance failures: preserve runtime targets when replacing symlink shims, respect active config homes, validate/activate cached Python per session, and keep checkout-specific base state. Claude installs now reconcile an ownership manifest, preserve host edits and memory, and reject cross-checkout plugin mutations. Startup dependents execute sequentially. Bootstrap failures retain diagnostics and independent guidance; plugins-only setup requires persisted ownership, and legacy Codex profile migration requires explicit access-profile selection.
Aligns Claude/Cursor reviewers with canonical focused verification and current-host capabilities. The Semgrep workflow checks local capability before authorized network work and requires every approved scan/artifact pair to complete. New offline rule contracts cover routing, dependencies and scanner examples; activation guidance separates source, installed host and loaded context.
Browser checks now wait through the confirmed streamed canonical-redirect navigation without hiding other evaluation errors. The prescribing phone clearance test reissues its endpoint action against the live scroll range and brackets its geometry measurement with endpoint checks, retaining the existing dock visibility and clearance assertions.
Areas touched: Knowledge and records, Delivery and assurance, App experience
Verification
UI verification not run: full
npm run verify:uiwas deferred locally under the focused-verification policy; complete affected tools/hydration specs passed (107 tests), and all required hosted production browser partitions have now passed in CI39017019663. This is focused browser proof, not a claim that the full local UI gate passed.Browser repair:
107 passed (3.1m)for the complete tools and hydration specs across Chromium/Chromium mockups on an isolated offline production build. Hydration behavioral/contract regressions:16 passed (16). A controlled late 78px range expansion reproduces the original phone failure before the fix and passes afterward; the temporary diagnostic injection is absent from the patch.Whole-tree formatting, changed-file lint, organisation placement, diff integrity and normal commit hooks pass. Independent review covers both fixes. The first local production run compiled but its TypeScript worker exhausted the default 4GB heap; the successful rerun used command-scoped
NODE_OPTIONS=--max-old-space-size=8192, with typechecking and browser assertions enabled.The concurrent external endpoint-repair commit is preserved in history. The merge's complete Git tree exactly matches the locally verified source tree. Hosted CI39017019663 and its PR required gate passed on exact head
6bfe9b9d5a093cf26a2bcd0a7ffb9d1f97ad6892(observed 2026-10-17 08:46:37 UTC). All production UI partitions and critical UI, unit coverage, static/safety/build/container checks, SAST and Secret Scan passed.Checks run: initial 18 focused suites, 902 tests passed; follow-up Codex policy (151), Claude lifecycle/setup (95), rule/scan (29), handoff-hook (28) and headroom/rule (41) runs passed. Counts are separate runs with overlap. Source typecheck and changed-file lint passed.
Instruction retirement/budgets, rule consistency (22 active sources), 35 canonical skills, gate manifest, diff integrity, documentation links/scripts/inventory, repository-awareness snapshot and formatting passed.
Synthetic homes/CLIs/listeners only; no actual home provisioning, scanners, memory calls or production/provider validation.
Hosted CI: 39017019663 passed on the exact published repair head, including the required gate and all applicable static, unit coverage, build, browser and container jobs. SAST, Secret Scan, PR Policy and mergeability checks also passed. Local focused proof remains distinct from the full local UI gate; no merge or deployment is claimed.
Risk and rollout
Notes
Browser changes are test-harness repairs only; no application source changed. They remain on this PR to repair its reported CI failures; the operational source changes and browser-repair commit remain independently revertible.
Independent reviews and isolated regressions covered the setup defects, stale instruction routes, temp-file/permission safety, wrong-owner plugin mutation and partial scan completion. Shared master rules and historical evidence remain unchanged.
Summary by CodeRabbit
New Features
Improvements
CodeAnt-AI Description
Protect Cloud configuration across checkouts and report incomplete setup or scans
What Changed
Impact
✅ Host edits and personal Claude memory survive profile updates✅ Cloud checkouts keep separate configuration and base caches✅ Incomplete Semgrep scans cannot pass as complete✅ Fewer false browser failures after redirects or late page growth💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.