Repository navigation
Walk back the riskiest unreviewed parts of PR #3538 #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+380
−235
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e5aea11
fix: walk back the riskiest unreviewed parts of PR #3538
claude 9a8a2d9
fix: 2 findings — Leave unknown age unclassified; Print a visible use wa
qodo-code-review[bot] 3f74b53
fix: Reuse embeddings when therapy text is unchanged
qodo-code-review[bot] 2f6ae67
fix(forms): show a not-for-use warning and no default age period on t…
claude 5cee6af
Merge Qodo's branch pushes, keeping this PR's own versions
claude 11ce38b
fix(forms): stop the 6B threshold claiming Chief Psychiatrist consent…
claude 7e3657a
fix(forms): state 6B needs Chief Psychiatrist consent rather than inv…
claude 572f53b
Merge remote-tracking branch 'origin/main' into claude/project-thread…
claude 1095b5a
Merge remote-tracking branch 'origin/main' into claude/project-thread…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
docs/outstanding-issues-inbox/0a3b873b-ce2c-486b-ab9c-b364129022e9.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "0a3b873b-ce2c-486b-ab9c-b364129022e9", | ||
| "createdOn": "2026-10-15", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P3", | ||
| "type": "task", | ||
| "summary": "Remove PR 3538 leftovers once the 30-day dead-code window passes (after 13 Nov 2026)", | ||
| "detail": "The /api/proxy route only replies authenticated and nothing calls it. scripts/recalculate-answer-support-labels.ts and its test are run by nothing. The 11 developer tool pages under src/app/mockups/development are now unreachable duplicates of /admin/developer-hub. The safe-number editor, attendance roster, QR check-in helper and clinical note editor are unwired; wire or remove each, and the note editor needs a privacy review before use. The clinical-math calculators need ideal body weight guidance, a corrected lithium dialysis label, a consistent 1.2 mmol/L boundary and tablet-strength rounding before any use.", | ||
| "source": "PR 3538 review, 15 Oct 2026", | ||
| "issueUlid": "01M4ZM796108216B8VGP235CHK" | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
docs/outstanding-issues-inbox/0f007792-605d-4f25-af8d-89f7c2ed95be.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "0f007792-605d-4f25-af8d-89f7c2ed95be", | ||
| "createdOn": "2026-10-15", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P2", | ||
| "type": "issue", | ||
| "summary": "PR 3538 raised every bundle size budget without a recorded approval", | ||
| "detail": "bundle-budget.json total production budget rose about 8 percent and compressed about 17 percent, and all 13 route budgets rose 2 to 10 percent, while the comment still cites only the 13 Oct approval for two routes. Measure the real sizes and either find the growth or record the owner approval for the new baseline.", | ||
| "source": "PR 3538 review, 15 Oct 2026", | ||
| "issueUlid": "01M4ZM797AVHR3TJ7Y3CWK3H4T" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
docs/outstanding-issues-inbox/145b648c-1cc9-4283-a136-2d0e02ac53cf.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "145b648c-1cc9-4283-a136-2d0e02ac53cf", | ||
| "createdOn": "2026-10-15", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "9f54ed09-1500-4eba-90b1-0a25a148d3cf", | ||
| "reason": "PR 3538 review (15 Oct 2026): scripts/recalculate-answer-support-labels.ts is run by nothing and uses its own 0.82/0.64 thresholds that production does not use; its test checks that copy, not the live label logic. The separate storage-version done request stands." | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
docs/outstanding-issues-inbox/15c1027e-6835-49eb-bd98-54f697b3388c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "15c1027e-6835-49eb-bd98-54f697b3388c", | ||
| "createdOn": "2026-10-15", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P2", | ||
| "type": "task", | ||
| "summary": "Check the live Tall Man drug lettering list against the ACSQHC National Tall Man list", | ||
| "detail": "src/lib/medications/tall-man.ts is live on medication search and record pages but was never checked against the official list. Doubtful: citaloPRAM/escitaloPRAM and fluPENtixol/zucloPENthixol capitalise the shared stem so they do not separate the pair, CLONazepam differs from ISMP clonazePAM, and VALproate, midazolAM, temazePAM, oxazePAM need checking. Matching is exact-name only. Needs owner verification.", | ||
| "source": "PR 3538 review, 15 Oct 2026", | ||
| "issueUlid": "01M4ZM794RF3B2XCAJ2YDRJ8FG" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
docs/outstanding-issues-inbox/5357c11a-9e2e-4f23-9474-87e40db67b3d.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "5357c11a-9e2e-4f23-9474-87e40db67b3d", | ||
| "createdOn": "2026-10-15", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "e978e1fd-70a4-43f3-a547-6f7e67ff3bf8", | ||
| "reason": "PR 3538 review (15 Oct 2026): the component exists with tests, but no page in the app renders it, so the item is not done for a clinician." | ||
| } | ||
| } |
14 changes: 14 additions & 0 deletions
14
docs/outstanding-issues-inbox/8eed5dff-8f00-4b4d-9e42-22d3588d9164.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "8eed5dff-8f00-4b4d-9e42-22d3588d9164", | ||
| "createdOn": "2026-10-15", | ||
| "action": "add", | ||
| "payload": { | ||
| "pri": "P1", | ||
| "type": "issue", | ||
| "summary": "Unwired WA MHA Form 6A/6B print component carries unverified statutory text", | ||
| "detail": "src/components/forms/wa-mha-form-print.tsx (PR #3538) says Form 6B needs Chief Psychiatrist consent, while src/lib/form-register.ts calls the 6B attachment a report to the Chief Psychiatrist. Section lists, the 7-day pre-expiry examination and copy recipients are unverified, and it prints WA Government branding. Fabricated default patient, clinician and consent values were removed on 15 Oct. Nothing renders it. Delete it once the 30-day dead-code window passes (after 13 Nov 2026) unless legal and clinical sign-off is obtained first.", | ||
| "source": "PR 3538 review, 15 Oct 2026", | ||
| "issueUlid": "01M4ZM793BWFYDV65NNBHBP53K" | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
docs/outstanding-issues-inbox/9f5e9e17-6b34-4f91-adc2-ba1275821021.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "9f5e9e17-6b34-4f91-adc2-ba1275821021", | ||
| "createdOn": "2026-10-15", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "563d11b8-515b-402e-a3ae-ef8ba5991105", | ||
| "reason": "PR 3538 review (15 Oct 2026): the component exists with tests, but no page in the app renders it, so the item is not done for a clinician." | ||
| } | ||
| } |
10 changes: 10 additions & 0 deletions
10
docs/outstanding-issues-inbox/ecbe4970-41ef-45e7-b731-6f31a5df480c.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": 2, | ||
| "id": "ecbe4970-41ef-45e7-b731-6f31a5df480c", | ||
| "createdOn": "2026-10-15", | ||
| "action": "cancel", | ||
| "payload": { | ||
| "requestId": "b820ca6c-4882-4a09-85c7-a87505cb0f20", | ||
| "reason": "PR 3538 review (15 Oct 2026): the component exists with tests, but no page in the app renders it, so the item is not done for a clinician." | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.