Repository navigation
Walk back the riskiest unreviewed parts of PR #3538 - #3553
Conversation
- WA MHA 6A/6B print component: remove fabricated default patient, clinician, clinical reasoning and pre-ticked Chief Psychiatrist consent; blank fields now print as 'Not entered'. Mark it not for use until the statutory text has legal and clinical sign-off. - Restore 'This final point is a clinical inference.' in Advocacy-informed therapeutic work, so the inference no longer reads as RANZCP's; rebuild the therapy index and site-content baseline. - Guard the sixth therapy record #3538 reset to needs_review. - Medicines and differentials list routes: restore the earlier rule that only the uninitialised seed gets long public caching, so corrections to live records are not held in shared caches for up to an hour. - Ledger inbox: cancel four pending 'done' requests for components no page renders, and queue the follow-ups (MHA form, Tall Man list check, 30-day cleanup, bundle budget raise). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 16 minutes. View limit details
✨ Finishing Touches: 💡 1
Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoRestore clinical safeguards and conservative catalogue caching
AI Description
Diagram
High-Level Assessment
Files changed (17)
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
Re Qodo finding 1 ("One therapy edit re-embeds every therapy"): confirmed, and not fixing it in this PR. Path traced: any edit to Why it stays as is: the fix changes the site-content lineage contract and the embedding reuse rules, which is well outside a one-sentence clinical text restoration. The cost is one batch of embedding calls on the next sync, and nothing is wrong in the output. Worth its own change if it matters to the owner. Generated by Claude Code |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
- Leave unknown age unclassified - Print a visible use warning
Qodo Fixer✅ Committed (3) · ☑ Fixed (3) Commits pushed directly to this PR — no separate fix PR opened. Process — 3 fixed
|
…he MHA print draft Addresses review findings on #3553: the not-for-use note now prints on the form itself, and an omitted age class prints 'Not determined' rather than the adult 21-day period. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
Qodo pushed two commits to this branch. The form fix duplicated 2f6ae67, so this branch's version is kept. The embedding-reuse change drops the lineage check from site-content sync, a behaviour change the PR author declined in review; it is not taken here and needs its own reviewed PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
|
Qodo pushed two commits to this branch (9a8a2d9, 3f74b53). They are merged in 5cee6af, but their changes are not kept:
The tree at 5cee6af is identical to 2f6ae67. Generated by Claude Code |
… was obtained Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
|
Code review by qodo was updated up to the latest commit 5cee6af |
|
Code review by qodo was updated up to the latest commit 11ce38b |
|
Re Qodo finding "The form still asserts an unchecked rule": agreed, fixed in the next commit (not yet pushed). The 6B threshold now reads "Chief Psychiatrist consent required (status shown below)", which keeps the stronger consent prerequisite without claiming consent was obtained. The whole component remains unwired and carries the visible not-for-use warning until legal and clinical sign-off. Generated by Claude Code |
…olvement Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
|
Code review by qodo was updated up to the latest commit 7e3657a |
CodeAnt PR Risk: Low Risk
Assessed commit: |
…-4nhja3 # Conflicts: # tests/fixtures/site-content/static-manifest-baseline.json
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · WA mental-health form output changes consent and period wording; unverified statutory details could mislead if the component is later used clinically. Walks back the unreviewed parts of PR #3538: blank WA MHA form fields now print "Not entered", consent defaults to pending with a not-for-use note, the clinical inference marker is restored, and public caching for medicine and differential lists is limited to uninitialised seeds. Resolved the age classification and max period print spacing issue. No open issues remain. ✅ 1 closed✅ Quality: Age classification and max period print run together with no gap
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 6 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
qodo-code-review
Bot
added
🔴 Large blast radius
and removed
🟠 Medium blast radius
labels
|
Code review by qodo was updated up to the latest commit 1095b5a |
User description
Requested by Josh · project thread
Summary
Before: PR #3538 merged without human review. It left an unused WA MHA Form 6A/6B print component that printed a fictional patient, a fictional doctor, invented clinical reasoning and a pre-ticked "Chief Psychiatrist consent" whenever a field was blank. It removed the "This final point is a clinical inference." marker from Advocacy-informed therapeutic work, so an inference read as RANZCP's. It also let signed-out visitors' medicine and differential lists be held in shared caches for up to an hour (and served stale for up to a day).
After: blank MHA form fields print "Not entered" and consent defaults to pending, with a not-for-use note until the statutory text has legal and clinical sign-off. The inference marker is back. The list routes return to the earlier rule that only the uninitialised seed gets long public caching. The ledger no longer records four unwired components as done, and the follow-ups are queued.
/api/medicationsand/api/differentials:fixtureback toobserved.source === "seed_uninitialized", exactly as before feat(audit): comprehensive repository audit remediation and frontend hardening #3538.How: deleting the MHA component,
/api/proxy, the support-label script and the duplicate developer pages was the first plan, butcheck:dead-code-candidaterefuses anything introduced within 30 days. They are neutralised or logged for removal after 13 Nov 2026 instead. The bundle budget raise is logged rather than reverted, since resetting a baseline without measuring would only turn CI red.Areas touched: Clinical reference content, Knowledge and records, App experience, Delivery and assurance
Verification
npm run verify:cheap:Test Files 1881 passed (1881),Tests 29881 passed | 5 skipped, exit 0npm run check:therapy-data-index:Therapy indexes are current (205 records).npm run check:diff-integrity:PASS — 2 changed test file(s), 4 -> 5 test case(s)Existing route tests pass with both the old and the #3538 caching rule, so neither direction was pinned by a test.
Risk and rollout
Notes
reviews/pr-3538-review-2026-10-15.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01TZemPFt7NxcpnCTge8cLbg
Generated by Claude Code
Summary by cubic
Walks back the riskiest unreviewed parts of PR #3538, which merged without human review and shipped fabricated clinical content and over-broad public caching.
/api/medicationsand/api/differentialsreturn to long public caching only for uninitialised seeds, so corrections to live records are not served stale from shared caches for up to an hour.Written for commit 1095b5a. Summary will update on new commits.
Summary by Gitar
isChildnow prints "Not established" and omits the maximum initial period in the WA MHA formlineageFingerprintchanges and the text is unchangedThis will update automatically on new commits.
CodeAnt-AI Description
Remove invented form details and keep recovering catalogue data fresh
What Changed
Impact
✅ No invented details on blank form drafts✅ Clear warning on unverified WA form drafts✅ Fresher medicine and differential lists during recovery💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.