Repository navigation
Fix confirmed documentation drift from the audit review, reset First Nations letter on region change, queue ledger requests - #3522
Conversation
…d queue ledger requests Documentation (each claim re-checked against main 4382217 before editing): - DR runbook: correct the GUC name (app.indexing_v3_agent_base_url) and its production-host fallback, stop telling the operator to re-create the retired ingestion cron job, drop the undated 102-migration count - db-maintenance, launch-operator, observability-slos (digest is daily), deployment-architecture (dockerfilePath, not RAILWAY_DOCKERFILE_PATH), reindex-runbook (active_agent_enrichment), operations-runbook (real query locations and page size) - verify:cheap -> verify:full for branch-review-ledger and branch-review-archival-policy - testing.md and README.md (matrix scope, test:focused example) - design-system ADOPTION/GATES/SPEC prose, .design-sync/conventions.md, clinical-governance label - design-review agent and audit skill now use ledger:lookup / ledger:append Code: First Nations "Where is home" clears the letter when the region changes. Not run: typecheck and unit tests (no installed dependencies in this environment). Ledger: 13 immutable add requests under docs/outstanding-issues-inbox for the confirmed issues that are not fixed here. Not reconciled. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013fpAhwc33X7YgFkDu3pa18
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 5 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Summary by CodeRabbit
WalkthroughThe PR changes region selection so that reselecting the active region retains the prepared letter, while switching regions clears it. It also updates repository guidance, design-system and operational documentation, and adds outstanding-issue records. ChangesRegion selection
Repository guidance
Design-system documentation
Operational documentation
Outstanding-issue records
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Verification Claims |  |
The PR description still claims, “Every claim was re-checked against main (4382217) before editing,” but it does not name an exact audit command or check and its result. The separate Verification sect… | Add the exact audit command or check and its result, for example Ran <exact audit/check command>: passed or found <specific result>. If no reproducible audit check was run, state Not run: <reason> and remove the unsupported claim. |
-
Check name Status Explanation Title check The title clearly identifies the three main changes: documentation corrections, First Nations letter reset behavior, and ledger request queuing. It is somewhat long but remains specific and relevant. Description check The description includes the required Summary, Verification, Risk and rollout, and Notes sections. It documents changed areas, verification results, skipped checks, risk, rollback, and production effe… Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 70.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (3 skipped: 3 … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Generated And Sensitive Files No prohibited sensitive or local/generated artifact was introduced. The changed-file inventory contains documentation, source, tests, and 13 small docs/outstanding-issues-inbox/*.jsonrecords. Those…Risky Git Or Deployment Actions No changed instruction recommends force-push, hard reset, destructive clean, branch deletion, or shared-branch rebase. The new deployment commands in docs/db-maintenance.md:106-111require an explic…Supabase Project And Schema Safety No custom-check failure is introduced. The only project-identity change corrects docs/clinical-governance.mdtoPsychSift Productionwhile preserving the established refsjrfecxgysukkwxsowpy. Th…Runtime And Package Manager Integrity PASS. The pull request does not change package.json, package-lock.json, .node-version, .nvmrc, or .npmrc. The head still declares npm@11.17.0, Node >=24.15.0 <25, npm 11.x, and engine-strict=true. Add… Api Route Failure Handling No API route, server action, RAG, search, ingestion, or provider integration implementation changes are present. The production code change is local React state handling in `src/components/first-natio…
Full details: Verification Claims
-
Explanation
The PR description still claims, “Every claim was re-checked against main (4382217) before editing,” but it does not name an exact audit command or check and its result. The separate Verification section names several commands with results and marks other checks as not run, but it does not substantiate this audit re-check claim.
✨ Finishing Touches
-
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Merging this PR will not alter performance
|
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoCorrect audit-confirmed guidance and clear stale First Nations letters
AI Description
Diagram
High-Level Assessment
Files changed (32)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d48406a3a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
CodeAnt Nitpicks2 code suggestions1. This calls 28px the chip text size, but
|
Qodo Fixer✅ Committed (1) · ☑ Fixed (1) Commits pushed directly to this PR — no separate fix PR opened. Process — 1 fixed
|
|
Code review by qodo was updated up to the latest commit 3dfbe5b |
…is not a health probe
|
Code review by qodo was updated up to the latest commit 032fb8e |
|
Auto-fix: 1 flaky check. View session →
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
Auto-fix: 2 checks fail without this pull request. View session →
|
|
No code changes since the last review — review skipped |
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Clearing contacts on region switches may discard a draft, while revised restore steps could misconfigure cron or database settings if misapplied. Resets the First Nations service letter when the home region changes in ✅ 1 closed✅ Bug: Map region selection still keeps the stale letter
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
User description
Summary
Fixes the simple, confirmed items from the review of 16 audit reports. Every claim was re-checked against
main(4382217) before editing; the audits themselves were partly wrong, so nothing was applied from their suggested text without re-deriving it.db-maintenance.mdnamed a database setting that does not exist (app.indexing_agent_url). The real one isapp.indexing_v3_agent_base_url, which falls back to the production host when unset.20260926041000retired.launch-operator-runbook.mdsays "at least" instead of "exactly" for the retention jobs.observability-slos.mdcalls the ops digest daily, with a note that the scheduled run cannot meet the three-contiguous-hour page rule.deployment-architecture.mdnamesdockerfilePathinrailway.worker.jsoninstead of a non-existentRAILWAY_DOCKERFILE_PATH.reindex-runbook.mdgains theactive_agent_enrichmentbullet.operations-runbook.mdpoints at the real query locations and page size (1000).branch-review-ledger.mdandbranch-review-archival-policy.mdsaid their check runs inverify:cheap; it is averify:fullstep.docs/testing.mdexplains the old 70-minute timeout as historical (matrix legs are now capped at 45).README.mdstates the real scope ofrelease-browser-matrixand that it is not part ofpr-required, and thetest:focusedexample now uses<paths>.ADOPTION.mdcounts,GATES.mdtap-floor ratchet,SPEC.md"planned" checks that ship,.design-sync/conventions.mdtap size / radius map /--commandcolour, and the Supabase label inclinical-governance.md(:67only; the dated 2026-06-28 section is left alone).design-reviewagent andauditskill now useledger:lookup/ledger:appendinstead of hand-editing the ledger.src/components/first-nations/where-is-home.tsxclears the letter when the region changes, so Copy cannot paste region A's service numbers while region B is shown.addrequests underdocs/outstanding-issues-inbox/for the confirmed issues not fixed here. They are not reconciled, as the/issuesskill requires.Areas touched: Knowledge and records, Data platform and access, Design system, Delivery and assurance, App experience, Clinical reference content, Source intake and indexing
RAG impact: none. No ranking-protected file is touched and no retrieval behaviour changes.
Verification
prettier --checkon all 19 changed files: "All matched files use Prettier code style!" (3.9.9, same result as before the edits).node scripts/check-docs-links.mjs: "docs link check passed: 5764 repo path references resolve."node scripts/check-docs-script-refs.mjs: "docs script-ref check passed: 851 npm-run reference(s) resolve to real scripts."check-instructions.mjs: "retired-rules: pass";instruction-budget: pass(AGENTS.md 23,977 of 24,000 bytes, unchanged by this PR).check-codebase-index-coverage.mjs: "coverage OK";update-docs-inventory.mjs --check: within tolerance.check-outstanding-issues.mjs: "passed: 858 rows (141 open, 717 archived)";check-ledger-write-discipline.mjs: "passed for 4382217..HEAD".typecheck, unit tests,verify:cheap,verify:full, any browser test. Dependencies are not installed in the environment this was prepared in, so thewhere-is-home.tsxchange is unverified beyond reading it. CI is the first real run of it. No DOM test was added for it.scripts/organisation/decisions.mjsreports one warning aboutdocs/decisions/2026-08-22-automated-review-coverage.md; it is present onmainwithout this change.Risk and rollout
db-maintenance.md) narrow or correct existing steps and add no new action.Notes
docs/outstanding-issues.md(canonical ledger; its corrupted arrow on line 15 is recorded in a ledger request instead), the privacy-document encoding repair, script header comments underscripts/**, and anything needing a migration (e.g. thedisplay.revokeNULL guard) or an owner decision.display.revokeguard,listOwnerTeamsN+1,InboxRecordcast, the "Top match" test and its duplicate render, test-deletion guard blind spots, On Call identifier-guard coverage, Roster overlap check, week-strip / all-day / holiday gaps,sast.ymlandeslint-rules, safety-document line anchors, script-header claims, and remaining doc drift.🤖 Generated with Claude Code
https://claude.ai/code/session_013fpAhwc33X7YgFkDu3pa18
Generated by Claude Code
Summary by cubic
Fixes confirmed documentation drift from the audit review, resets the First Nations contact letter when the home region changes, and queues the remaining confirmed issues in the ledger.
Operator runbooks and gates
invoke_indexing_v3_agent; restore steps runALTER DATABASE ... SETaspostgresand verify viapg_db_role_settingor a new connection.supabase/config.toml, verifyOPENAI_API_KEYby name, and warn that aPOSTtosite-content-syncclaims queued outbox events rather than serving as a health probe; a new test asserts each one has a deploy command.verify:full, the 70-minute timeout is documented as historical,release-browser-matrixis not part ofpr-required, and the daily ops digest cannot meet the three-contiguous-hour RPC page condition on its own.design-reviewagent andauditskill now useledger:lookup/ledger:append.Code and ledger
where-is-home.tsxclears the letter on a region switch but keeps it on same-region reselect, covered by a new DOM test.addrequests queue the confirmed issues not fixed here, including the migration-gateddisplay.revokeguard and owner-decision items.Written for commit e62d72f. Summary will update on new commits.
CodeAnt-AI Description
Clear regional letters on region changes and correct recovery guidance
What Changed
Impact
✅ Prevents copying contact numbers for the wrong region✅ Reduces risk of misdirected indexing requests after a restore✅ Clarifies which checks block a merge💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.