Repository navigation
fix(compose): make the worker opt-in and require an explicit Supabase URL - #3642
Conversation
… URL A local `docker compose up` with production keys started a worker on the live ingestion queue, and the app build silently defaulted NEXT_PUBLIC_SUPABASE_URL to the production project. - Remove the production Supabase URL default; Compose now fails fast unless NEXT_PUBLIC_SUPABASE_URL is supplied. - Put the worker behind profiles: [worker] and drop the app's depends_on: worker. - Remove the obsolete version: "3.8" key. - Load .env.local via env_file with required: false. - Bind the worker's /health server on internal port 8080 and add a Compose healthcheck for it. - Update the README Compose section to match.
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 42 minutes. View limit details
✨ Finishing Touches
Comment |
PR Summary by QodoMake the Compose worker opt-in and require a Supabase URL
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13bed43642
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8080 is Medications' API port, so sibling-repo port-isolation audits flagged the Compose worker health port as a collision.
…com/BigSimmo/PsychSift into fix/compose-worker-profile-20261018
|
Code review by qodo was updated up to the latest commit b8220df |
CodeAnt Nitpicks1 code suggestion1. /health runs a five-second Supabase probe followed by a Python check that can also take five seconds, so successful combined checks can exceed this timeout and fail.Possible bug · |
CodeAnt PR Risk: Medium Risk
Assessed commit: |
… example - Pass NEXT_PUBLIC_SUPABASE_STAGING_PROJECT_REF/NAME build args so the browser project guard accepts an explicitly configured staging URL. - Use --env-file .env.local in the header's worker startup example.
Code Review ✅ Approved 1 closed / 1 findings🟡 Medium risk · Making the ingestion worker opt-in and requiring an explicit Supabase URL changes Compose startup behavior; misconfiguration could still target an unintended project. Makes the worker opt-in via a Compose profile and removes the production Supabase URL default so ✅ 1 closed✅ Bug: README stop command fails:
|
| Auto-apply | Compact |
|
|
Important
Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
|
Code review by qodo was updated up to the latest commit a55c453 |
Summary
Docker review finding: a local
docker compose upwith production keys in.env.localstarted a worker that claims from the live ingestion queue, and the app build silently defaultedNEXT_PUBLIC_SUPABASE_URLto the production project.sjrfecxgysukkwxsowpy). Compose now fails fast (${NEXT_PUBLIC_SUPABASE_URL:?...}) unless the variable is supplied.workerbehindprofiles: [worker]and drop the app'sdepends_on: worker, so a plainupstarts the app only.version: "3.8".env_file: [{ path: .env.local, required: false }]for both services.WORKER_HEALTH_PORT=3901(internal only, nothing published; not 8080 so the Medications sibling port-isolation audit does not flag a collision) soworker/health.tsbinds, and add a Compose healthcheck on/health.--profile worker), and--env-file .env.localfor bothupanddown(thedownfix came from the Qodo review bot), because${...}interpolation does not readenv_file.Areas touched: Delivery and assurance, Knowledge and records
Verification
docker compose config -q(compose v2.39.4) with noNEXT_PUBLIC_SUPABASE_URL→required variable NEXT_PUBLIC_SUPABASE_URL is missing a value(exit 1)config --services→apponly;--profile worker config --services→app,worker; nodepends_onin the rendered config; config renders without a.env.localfile presentprettier --check README.md docker-compose.yml→All matched files use Prettier code style!docs:check-links→docs link check passed;docs:check-scripts→docs script-ref check passedRisk and rollout
Notes
docker compose upstarting the worker must now add--profile worker, which needs connected-workload approval.